Skip to content

Comments

Feature/init mcp server#1

Merged
galic-vlad merged 1 commit intomainfrom
feature/init-mcp-server
Dec 17, 2025
Merged

Feature/init mcp server#1
galic-vlad merged 1 commit intomainfrom
feature/init-mcp-server

Conversation

@galic-vlad
Copy link
Collaborator

@galic-vlad galic-vlad commented Dec 3, 2025

Init mcp-vmanomaly

Create mcp-vmanomaly MCP server with a structurte similar to mcp-victoriametrics

@galic-vlad galic-vlad force-pushed the feature/init-mcp-server branch 2 times, most recently from 34fa936 to 02eb65e Compare December 4, 2025 12:03
Copy link
Collaborator

@Amper Amper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments after a quick glance. I'll take a closer look tomorrow.

@galic-vlad
Copy link
Collaborator Author

@Amper I resolved comments you left. Do you have any additional comments/concerns?

@Amper
Copy link
Collaborator

Amper commented Dec 12, 2025

I reviewed the code and have no comments (I cannot verify the logic, as I have no knowledge of VMAnomaly).
Only one my question - you don't use tool annotations — is that intentional?

@Amper
Copy link
Collaborator

Amper commented Dec 15, 2025

i'm not sure that removing SSE is good idea, because when i checked a couple months ago there still were several clients that support only SSE and doesn't support streamable HTTP

@galic-vlad
Copy link
Collaborator Author

galic-vlad commented Dec 16, 2025

streamable HTTP

In the vmanomaly team, we discussed that SSE transport is becoming unsupported and that all popular clients already support streamable HTTP. Therefore, for the new MCP server release, we could choose not to support the legacy SSE transport.

TBH, it isn't very hard to support SSE since mcp-go still handles it. Maybe we should plan to deprecate SSE in the future, only once/if mcp-go decides to exclude it from the default transport options. So users with older clients versions or cleints with poor maintaince, may also use our MCP.

@fred-navruzov what do you think?

@galic-vlad galic-vlad force-pushed the feature/init-mcp-server branch from 7a5a2d2 to 0120bfb Compare December 17, 2025 07:29
@galic-vlad
Copy link
Collaborator Author

@Amper thanks for highlighting the possible problem with SSE mode for our clients. I've restored support for it, but I added a note to the README that HTTP is preferred and mentioned the possible future deprecation of SSE transport.

We are ready to merge and release the first version. Once I merge it into main, can we transfer the ownership of this repo to Victoriametrics-Community organization?
image

Seems I need permissions to create repos here

Repository transfers and organizations
To transfer repositories to an organization, you must have permission to create repositories in the receiving organization, and to transfer repositories out of the origin organization. An organization or enterprise owner may have set a policy that prevents certain users from doing these things.

Once a repository is transferred to an organization, the organization's default repository permission settings and default membership privileges will apply to the transferred repository.

Or instead, I can transfer it for you @Amper , and u then transfer it to Victoriametrics-Community.

What works better? Or we should ask someone else for the help with this transfering?

@galic-vlad galic-vlad force-pushed the feature/init-mcp-server branch 2 times, most recently from 622e256 to df8ebf0 Compare December 17, 2025 07:47
@Amper
Copy link
Collaborator

Amper commented Dec 17, 2025

@galic-vlad i've just sent you invitation to the organization:

image

@galic-vlad galic-vlad force-pushed the feature/init-mcp-server branch from 30e298a to 5fa12ee Compare December 17, 2025 13:42
@galic-vlad galic-vlad merged commit 3a3b89e into main Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants