Add some process metrics for GOOS=darwin #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makasim
force-pushed
the
process_on_darwin
branch
from
db59fa8 to
46180c6
Compare
Adds support for metrics: - process_start_time_seconds - process_cpu_seconds_total - process_virtual_memory_max_bytes - process_open_fds - process_max_fds Fixes #75 Inspired by https://github.com/prometheus/client_golang/blob/main/prometheus/process_collector_darwin.go
makasim
force-pushed
the
process_on_darwin
branch
from
46180c6 to
833ad3a
Compare
|
@valyala asked for your review since the PR adds a lot of files to the vendor. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 87.58% 88.68% +1.10%
==========================================
Files 12 12
Lines 1643 1388 -255
==========================================
- Hits 1439 1231 -208
+ Misses 153 106 -47
Partials 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
makasim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for process metrics on MacOS\Darwin. I added only those that do not require CGO.
Fixes #75
Inspired by https://github.com/prometheus/client_golang/blob/main/prometheus/process_collector_darwin.go