vmprobe: support service, pod and node #1720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
k8s-probes
branch
from
f8d412e to
0471833
Compare
AndrewChubatiuk
force-pushed
the
k8s-probes
branch
from
0471833 to
7077874
Compare
AndrewChubatiuk
force-pushed
the
k8s-probes
branch
from
7077874 to
7c135d5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewChubatiuk
force-pushed
the
k8s-probes
branch
from
7c135d5 to
03a6fa6
Compare
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
k8s-probes
branch
from
03a6fa6 to
d7890cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
spec.targets.kubernetesand deprecatedspec.targets.ingress.spec.targets.kubernetessupports besidesingressalsopod,serviceandnoderoles. later gateway api roles support can be easily addedadded
spec.targets.staticand deprecatedspec.targets.staticConfigfor consistencyfixes #1078, #1716