Fix external browser menu-item titles#2079
Merged
barijaona merged 5 commits intoViennaRSS:masterfrom Feb 18, 2026
Merged
Conversation
Eitot
added
the
changes localisations
This appears to be obsolete. Contrary to the comment, the shift is not used here, but the option key.
There do not appear to be any preferences for which this notification is sent that are of relevance here. -showUnreadCountOnApplicationIconAndWindowTitle is sent when the unread articles count is updated.
barijaona
force-pushed
the
feature/alternate-menu-items
branch
from
cd957b7 to
454e10b
Compare
barijaona
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the "Open … Page in External Browser" menu items aren't consistently treated as "alternate" menu items, even though the code indicates that they were intended to be. The menu item title was also supposed to match user preferences and display the default web browser name.
I have reworked the implementation by removing an unnecessary Interface Builder workaround (which seems to have become unnecessary over the years) and putting the title setters in the menu-item validation code (whereas before they were scattered across multiple objects).