Skip to content

Commit ad04301

Browse files
Add ruby 3.4 Support (#2189)
* add ruyb 3.4 * add changelog entry * fix spec * fix spec * fix specs for ruby-main
1 parent c5feaed commit ad04301

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,12 @@ jobs:
5959
- ruby_version: "3.3"
6060
rails_version: "8.0"
6161
mode: "capture_patch_enabled"
62+
- ruby_version: "3.4"
63+
rails_version: "8.0"
64+
mode: "capture_patch_disabled"
65+
- ruby_version: "3.4"
66+
rails_version: "8.0"
67+
mode: "capture_patch_enabled"
6268
- ruby_version: "head"
6369
rails_version: "main"
6470
mode: "capture_patch_disabled"

docs/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ nav_order: 5
1414

1515
*Joel Hawksley*
1616

17+
* Add ruby 3.4 support to CI.
18+
19+
*Reegan Viljoen*
20+
1721
## 3.21.0
1822

1923
* Updates testing docs to include an example of how to use with RSpec.

test/sandbox/test/rendering_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def test_render_inline_allocations
1616
MyComponent.ensure_compiled
1717

1818
allocations = (Rails.version.to_f >= 8.0) ?
19-
{"3.4.0" => 110, "3.3.6" => 129} :
19+
{"3.5.0" => 117, "3.4.1" => 117, "3.3.6" => 129} :
2020
{"3.3.6" => 120, "3.3.0" => 120, "3.2.6" => 118, "3.1.6" => 118, "3.0.7" => 127}
2121

2222
assert_allocations(**allocations) do

0 commit comments

Comments
 (0)