Default preview controller should not crash with config.action_controller.include_all_helpers = false
#2045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller.include_all_helpers = false` (fixes ViewComponent#1654)
… less generic The default Rails configuration loads the PreviewHelper for every controller. We should use specific method names to prevent name clashes with user-provided helpers.
triskweline
force-pushed
the
issue-1654-always-provide-view-source
branch
from
9ac2c87 to
c0faca6
Compare
Contributor
Author
|
This test fails for me on
|
Collaborator
|
@triskweline this seems to be happening across the code basses, @joelhawksley It seems rails main has yet another breaking change, I will investigate it when I have some time |
joelhawksley
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #1654.