Support treat turbo_stream the same as html #2206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails sets the format for `turbo_stream` responses to `turbo_stream`, which then falls back to the `html` format. ViewComponents need to do the same.
Author
|
Closing since this is already working on the |
Author
I was mistaken, this actually isn't yet fixed on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2025
What are you trying to accomplish?
Rails sets the format for
turbo_streamresponses toturbo_stream, which then falls back to thehtmlformat. ViewComponents need to do the same so that variants are correctly selected.What approach did you choose and why?
This is a hack to unblock us from using ViewComponents with variants in production, so it's pretty hacky at the moment.
Anything you want to highlight for special attention from reviewers?
I hope this sparks further discussion from maintainers who are more familiar with best practices for what's going on here.