Support opt-in Nokogiri HTML5 parsing #2209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noah-Silvera
force-pushed
the
main
branch
3 times, most recently
from
8b14c8d to
d3e4c53
Compare
In view components rendered for test, we should allow opt-in Nokogiri::HTML5 parsing Nokogiri::HTML is just an alias for Nokogiri::HTML4, so this is a non-breaking change.
Member
|
@Noah-Silvera thank you for your PR! I opted to just make this change the default in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In view components rendered for test, we should allow opt-in Nokogiri::HTML5 parsing
Nokogiri::HTML is just an alias for Nokogiri::HTML4, so this is a non-breaking change.
I was motivated to make this change because in my own app,
Nokogiri::HTML4was parsing my rendered HTML incorrectly (inserting spaces in the middle of data attributes), whileNokogiri::HTML5parsed it correctly.Example of the incorrect parsing