Support Rails 8.1 #2467
Merged
Support Rails 8.1 #2467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I just ran into this as well. It looks like this project uses https://github.com/thoughtbot/appraisal, so you may need to run the relevant appraisal command ( Edit: Oh, I just noticed you are a maintainer, so you probably know that already 😅. Thank you! |
|
Rails 8.1 was released, so would be nice to have it in |
This was referenced Oct 22, 2025
Spone
force-pushed
the
support-rails-head
branch
from
1d062c2 to
879141f
Compare
Collaborator
|
The require statement on view_component/base.rb should be moved to require "active_support/configurable" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Close #2471