Require view_component/version #2475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boardfish
approved these changes
Oct 24, 2025
Collaborator
boardfish
left a comment
boardfish
left a comment
There was a problem hiding this comment.
Guessing from recent history that these CI runs aren't a blocker to merging? Certainly shouldn't be a problem for something like this.
Spone
force-pushed
the
require-version
branch
from
1da071c to
be4afae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Make
ViewComponent::VERSIONaccessible to other gems by default.In
view_component-formwe need to add conditionals to some specs, depending on ViewComponent version. Currently, calling::ViewComponent::VERSIONfrom our code raises withuninitialized constant ViewComponent::VERSIONif we don't require it manually.What approach did you choose and why?
I added a
requireto the main lib file. That's the default when you generate a new gem withrails plugin new.