Skip to content

Allow component inheritance with child template overriding parent inline render #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow component inheritance with child template overriding parent inline render #2485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/view_component/compiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ def template_errors

errors << "Couldn't find a template file or inline render method for #{@component}." if @templates.empty?

@templates
# Only check templates defined on this component or template files (not inherited inline calls)
# to allow component inheritance where child has template file and parent has inline render
templates_to_check = @templates.select { |t| !t.inline_call? || t.defined_on_self? }

templates_to_check
.map { |template| [template.variant, template.format] }
.tally
.select { |_, count| count > 1 }
Expand Down
Loading