fix: pixelocr.recognize lines should be much more reliable now #545
+37
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now instead of checking if just 1 character is alphanum it checks if 50% of the string is instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves
RecognizeLinesby not just assuming the string is good if a single character isALPHA_NUM_SYMBOLSbut at least 50% of the string is.To not make this much slower I created a table. I'm not sure if there's a better way to initialize the table, I tried to do it with the ìnitialization
keyword but I couldn't figure out how to compile it so I just added it to theRecognizeLines` function instead.I also changed it's structed a little to my personal liking. Feel free to change anything you don't like