Conversation
|
I also added Python 3.5, 3.6, 3.7. 3.4 is not supported by |
a4bf2e2 to
530586a
Compare
|
I fixed 21 failures but 4 failures are remaining. They look hard for me to fix since expectations are not clear for me. https://github.com/rhysd/covimerage/runs/416658292?check_suite_focus=true And there are a few test failures which may be related to #90. and |
|
'Better Code Hub' CI fails but I don't have permission to see the results. |
blueyed
left a comment
There was a problem hiding this comment.
Thanks, this looks good!
(sorry for the late response also)
Do you want to update it with regard to the token?
Otherwise I can also do it myself.
| python-version: ${{ matrix.py }} | ||
| - name: Install tox | ||
| run: | | ||
| python -m pip install --upgrade pip |
There was a problem hiding this comment.
I'd prefer to use the installed/stable pip. Not that important though for now.
| # - uses: codecov/codecov-action@v1 | ||
| # with: | ||
| # token: ${{ secrets.CODECOV_TOKEN }} | ||
| # yml: .codecov.yml |
You can ignore it, it's just an experiment. |
|
Current status: https://github.com/rhysd/covimerage/runs/416658292?check_suite_focus=true I can look into them during the next days. |
|
what's the status of this PR, is it able to be merged? |
Related to #90
Hi,
This PR adds a minimal Windows CI with GitHub Action. It only runs unit tests and takes coverage with Python 3.8.
Here is an example of CI result:
https://github.com/rhysd/covimerage/runs/416425706?check_suite_focus=true
Currently several tests fail but I don't know the failures are due to #90.
Do unit tests run with
toxrequirevimornvimeditor command? Currently they are not installed. Please let me know if they are necessary. I'll add step to install them.EDIT: If you want to put a CI badge for this in README.md, please let me know. I'll do.