Skip to content

Build without warnings (-Wall -Wcompat)#155

Open
int-index wants to merge 1 commit intoVinylRecords:masterfrom
int-index:no-warnings
Open

Build without warnings (-Wall -Wcompat)#155
int-index wants to merge 1 commit intoVinylRecords:masterfrom
int-index:no-warnings

Conversation

@int-index
Copy link
Contributor

The following warnings should no longer get triggered:

  • -Wnoncanonical-monoid-instances
  • -Wnoncanonical-monad-instances
  • -Wstar-is-type

@int-index
Copy link
Contributor Author

The CI failure is not related to this patch. The problem is that test-suite aeson is not compatible with newer aeson (could be fixed either by updating the code or adding an upper bound).

I can rebase when this is addressed.

@acowley
Copy link
Contributor

acowley commented Nov 6, 2021

This kind of maintenance is greatly appreciated, thank you! I’ll look into the test suite issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants