-
-
Notifications
You must be signed in to change notification settings - Fork 393
feat: force pull #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: force pull #934
Conversation
Why are you including a packaged isomorphic-git version without documenting what you have changed? This is similar to how one would do a supply chain attack! I've checked some diff now of the generated files and they seem fine, but please create a pr to isomorphic-git first. Also, don't change config values of esbuild. |
Hahahah, sorry. I didn't even think of that perspective. As for why, it's because I added the merge strategies (only "ours" and "theirs") into the code - https://github.com/thegeneralist01/isomorphic-git/tree/merge-strategies. I didn't even think of submitting a PR to isomorphic-git, because there are more strategies and implementing only two would mean that the feature is half-baked. The correct SHA-1 hash after |
PS: just realized one could pin the package. In our case, that would be: |
completely missed this. Will do, thanks |
No need to do so actually. Completely missed the |
sorry, I didn't make this clear before - the PR can be reviewed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be great to add an option in the settings to set the strategy option (default, ours, theirs) permanently and therefore use that strategy for automatic sync as well.
- Integrate force param into pullChangesFromRemote - Get rid of the vendored package, use existing mergeDriver
- Revert the "force pull" code and terminology - Add conflict resolution strategies to settings
d6e31bd
to
0d3bbd2
Compare
Add a "force pull" command. This is rather just a normal pull with merge strategy
--strategy-option=theirs
, meaning it will automatically resolve merge conflicts with the remote's changes.This PR and #933 address the following issues:
Closes #702
Closes #872
Closes #906
Partially addresses #920