Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tests/VirtoCommerce.InventoryModule.Tests/VirtoCommerce.InventoryModule.Tests.csproj
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <NoWarn>NU1608</NoWarn> |
There was a problem hiding this comment.
Suppressed dependency conflict warnings hide incompatibilities
Medium Severity
Adding NU1608 to NoWarn in multiple projects suppresses package constraint conflict diagnostics instead of resolving them. That allows restore/build to proceed with potentially incompatible dependency graphs, which can surface later as runtime behavior changes, EF tooling failures, or unstable test execution after the .NET 10 upgrade.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to .NET10
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4328
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Inventory_3.1000.0-pr-159-5504.zip
Note
Medium Risk
Framework and dependency upgrades can introduce build/runtime and test runner incompatibilities (including EF tooling and xUnit v3 migration), though changes are largely configuration/package-level.
Overview
Upgrades the Inventory module to .NET 10 by retargeting all projects (
Core,Data, DB providers,Web, and tests) fromnet8.0tonet10.0and bumping the module version to3.1000.0.Aligns dependencies with the new platform line: updates VirtoCommerce package references (Platform/Core/Search/Catalog dependencies in
module.manifest) to3.1000.x, updates EF tooling/design packages to10.0.1, addsNU1608suppression where needed, and refreshes the webpackage-lock.json(notablywebpackand related transitive packages).Written by Cursor Bugbot for commit 0da06fd. This will update automatically on new commits. Configure here.