Skip to content

VCST-3874: OrderModuleController.PostProcessPayment refactoring#465

Merged
yuskithedeveloper merged 15 commits intodevfrom
support/VCST-3874-controller-refactoring
Sep 18, 2025
Merged

VCST-3874: OrderModuleController.PostProcessPayment refactoring#465
yuskithedeveloper merged 15 commits intodevfrom
support/VCST-3874-controller-refactoring

Conversation

@yuskithedeveloper
Copy link
Contributor

@yuskithedeveloper yuskithedeveloper commented Sep 8, 2025 •
edited by vc-ci
Loading

Description

Moved logic from OrderModuleController.PostProcessPayment to CustomerOrderService.PostProcessPaymentAsync

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-3874

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Orders_3.857.0-pr-465-1feb.zip

vc-ci
vc-ci reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.651
Timestamp: 08-09-2025T19:11:34

vc-ci
vc-ci reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.745
Timestamp: 08-09-2025T19:47:21

vc-ci
vc-ci reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.288
Timestamp: 08-09-2025T19:57:52

vc-ci
vc-ci reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.77
Timestamp: 09-09-2025T12:30:55

vc-ci
vc-ci reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.462
Timestamp: 09-09-2025T12:54:25

vc-ci
vc-ci reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.482
Timestamp: 09-09-2025T14:12:49

@yuskithedeveloper yuskithedeveloper marked this pull request as ready for review September 9, 2025 16:24
vc-ci
vc-ci reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 11.411
Timestamp: 09-09-2025T16:30:13

vc-ci
vc-ci reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.426
Timestamp: 09-09-2025T16:39:59

vc-ci
vc-ci reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.104
Timestamp: 11-09-2025T13:58:25

vc-ci
vc-ci reviewed Sep 11, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.522
Timestamp: 11-09-2025T14:14:15

artem-dudarev
artem-dudarev previously approved these changes Sep 15, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vc-ci
vc-ci reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.865
Timestamp: 15-09-2025T17:17:23

vc-ci
vc-ci reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.972
Timestamp: 15-09-2025T17:28:39

@yuskithedeveloper yuskithedeveloper merged commit fc0375f into dev Sep 18, 2025
8 checks passed
@yuskithedeveloper yuskithedeveloper deleted the support/VCST-3874-controller-refactoring branch September 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vc-ci vc-ci vc-ci left review comments

@artem-dudarev artem-dudarev artem-dudarev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuskithedeveloper @artem-dudarev @vc-ci