Skip to content

VCST-4323: Improve fulfillment center checks and logging #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlegoO merged 2 commits into from
Dec 24, 2025
Merged

VCST-4323: Improve fulfillment center checks and logging #480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf1814d
VCST-4323: Improve fulfillment center checks and logging
OlegoO Dec 24, 2025
c40890d
Refactor inventory reserve logic for clarity
OlegoO Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/VirtoCommerce.OrdersModule.Data/Handlers/AdjustInventoryOrderChangedEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ public virtual async Task ProcessInventoryChanges(GenericChangedEntry<CustomerOr
{
var reserveStockRequest = await GetReserveRequests(changedEntry);

if (reserveStockRequest.Items.Any())
if (reserveStockRequest.Items.Any() &&
!reserveStockRequest.FulfillmentCenterIds.IsNullOrEmpty())
{
await _reservationService.ReserveAsync(reserveStockRequest);
}
Expand Down Expand Up @@ -127,9 +128,9 @@ protected virtual async Task<InventoryReserveRequest> GetReserveRequests(Generic
if (request.Items.Any())
{
var fulfillmentCenterIds = await GetFulfillmentCenterIdsAsync(order.StoreId);
if (!fulfillmentCenterIds.Any())
if (fulfillmentCenterIds.IsNullOrEmpty())
{
_logger.LogInformation("GetReserveRequests: No fulfillment centers, store - {Store}, store - {Order}", order.StoreId, changedEntry.NewEntry.Id);
_logger.LogWarning("GetReserveRequests: No fulfillment centers, store - {Store}, store - {Order}", order.StoreId, changedEntry.NewEntry.Id);
}
request.FulfillmentCenterIds = fulfillmentCenterIds;
}
Expand Down