fix graph override bug for menuLink Types#4
Open
rizkengin wants to merge 1 commit intoVirtoCommerce:devfrom
Open
fix graph override bug for menuLink Types#4rizkengin wants to merge 1 commit intoVirtoCommerce:devfrom
rizkengin wants to merge 1 commit intoVirtoCommerce:devfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the current implementation for the
MenuLinkTypeandMenuLinkListTypedoes not support type override.for example if the MenuLinkType got overridden using
serviceCollection.AddSchemaType<MenuLinkTypeExtend>().OverrideType<MenuLinkType, MenuLinkTypeExtend>();it won't work and the schema will still show the base type.this pull request makes sure to fetch the correct type if the base type is overridden.