VCST-4710: Change TEntity constraint to IEntity in generic CRUD services#2987
Open
ksavosteev wants to merge 2 commits intodevfrom
Open
VCST-4710: Change TEntity constraint to IEntity in generic CRUD services#2987ksavosteev wants to merge 2 commits intodevfrom
ksavosteev wants to merge 2 commits intodevfrom
Conversation
|
ksavosteev
changed the title
vc-ci
reviewed
Mar 5, 2026
Contributor
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 8.164
Timestamp: 05-03-2026T14:50:18
vc-ci
reviewed
Mar 5, 2026
Contributor
vc-ci
left a comment
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.331
Timestamp: 05-03-2026T15:11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4710
Artifact URL:
Note
Medium Risk
Touches core generic CRUD/search/caching abstractions and changes the generic type constraints, which may ripple to downstream implementations and extension methods. Runtime risk is low, but compile-time/API compatibility issues are possible in modules that relied on
Entity-specific behavior.Overview
Updates the generic CRUD/search/caching stack (
ICrudService,IOuterEntityService,CrudService,SearchService, and caching regions) to accept models constrained toIEntityrather thanEntity, enabling use of non-Entitymodel types.In
CrudService, replaces use ofEntity.IsTransient()with a new overridableIsTransient(IEntity)helper (defaulting toId == null) when determining which models should be loaded as existing entities.Written by Cursor Bugbot for commit 2908fa0. This will update automatically on new commits. Configure here.
Image tag:
ghcr.io/VirtoCommerce/platform:3.1008.0-pr-2987-2908-vcst-4710-2908fa05