Fix: sync DB-generated values back to original models in CrudService.SaveChangesAsync

[alexeyshibanov]

Summary

• CrudService.SaveChangesAsync replaces changedEntry.NewEntry with a new model created via parameterless entity.ToModel() extension. This means the original model objects passed to SaveChangesAsync never receive DB-generated values (auto-incremented IDs, foreign keys, etc.)
• This fix adds an optional model parameter to the virtual ToModel method: ToModel(TEntity entity, TModel model = null). When model is provided, it updates in-place via entity.ToModel(model); when null, it creates a new instance (preserving existing behavior)
• The post-save loop now calls changedEntry.NewEntry = ToModel(changedEntities[i], changedEntry.NewEntry), routing through the virtual method so that downstream overrides (e.g. PaymentMethodsService.ToModel) are respected

Breaking change

The ToModel signature changed from ToModel(TEntity entity) to ToModel(TEntity entity, TModel model = null). Existing overrides will get a compile error and must update their signature. This is intentional — a compile error is better than a silent regression where the override stops being called.

Known overrides to update:

• PaymentMethodsService.ToModel

Motivation

Modules that need DB-generated values synced back to the caller's model objects are forced to copy-paste the entire SaveChangesAsync method just to change this single line. CustomerOrderService already does this. ShoppingCartService needs it too for the same reason.

Fixing at the CrudService level eliminates the need for per-module workarounds and ensures consistent behavior across all CRUD services.

Test plan

• Existing CrudServiceTests pass (7/7)
• Verify no regressions in module integration tests

🤖 Generated with Claude Code
Image tag:
ghcr.io/VirtoCommerce/platform:3.1008.0-pr-2988-bcae-crud-service-sync-model-after-save-bcae5eb5

---

Note

Medium Risk
Touches the generic CrudService used across modules and changes model-mapping flow after persistence; reflection-based override detection and in-place updates could affect downstream custom ToModel overrides and event payloads.

Overview
Fixes CrudService.SaveChangesAsync to sync database-generated fields back into the same model instances (e.g., IDs/keys) by mapping entities into the existing changedEntry.NewEntry instead of always creating a new model.

Introduces a new ToModel(TEntity entity, TModel model) overload that can update in-place, marks the old ToModel(TEntity) as obsolete, and updates read/save code paths to call the new overload while preserving legacy overrides via runtime override detection.

^{Written by Cursor Bugbot for commit bcae5eb. This will update automatically on new commits. Configure here.}

[vc-ci]

Review task created: https://virtocommerce.atlassian.net/browse/VCST-4749

[vc-ci]

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.975
Timestamp: 09-03-2026T14:29:29

[artem-dudarev]

The CrudService.ToModel() method should be called because it could be overridden, for example here:
https://github.com/VirtoCommerce/vc-module-payment/blob/4d4249bc2292ba2addef6df4b3f4d3c23ec53e8a/src/VirtoCommerce.Payment.Data/Services/PaymentMethodsService.cs#L78

[alexeyshibanov]

Good catch! Fixed — the loop now calls the virtual ToModel with a new optional parameter:

changedEntry.NewEntry = ToModel(changedEntities[i], changedEntry.NewEntry);

The ToModel signature changed to ToModel(TEntity entity, TModel model = null):

• model = null → creates a new object via entity.ToModel() (existing behavior for GetAsync and originalModel creation)
• model != null → in-place update via entity.ToModel(model) (new behavior for post-save sync)

This is an intentional breaking change for existing overrides like PaymentMethodsService.ToModel(entity) — they'll get a compile error and need to update their signature. A compile error is better than a silent regression where the override stops being called.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vc-ci]

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.825
Timestamp: 13-03-2026T11:32:07