-
Notifications
You must be signed in to change notification settings - Fork 1
Remove dead code and fix linting issues #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3910567
Add CodeRabbit AI integration configuration
AlmostBald-TRADING b342ca5
Fix all CodeRabbit AI reported issues
AlmostBald-TRADING 0f596ec
Remove CodeRabbit configuration from repository
AlmostBald-TRADING 16c4e90
Remove dead score function and fix linting issues
AlmostBald-TRADING 0bb6ac3
Fix CodeRabbit configuration schema
AlmostBald-TRADING f50bf37
refactor: merge redundant path entries in .coderabbit.yaml
AlmostBald-TRADING 4b0dfa6
docs(coderabbit): add optional external tools note and IaC review paths
AlmostBald-TRADING ae86695
Consolidate duplicate IaC/container path instructions in .coderabbit.…
AlmostBald-TRADING File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| # CodeRabbit AI Configuration for ContextForge Memory | ||
| # https://docs.coderabbit.ai/guides/code-review-best-practices/ | ||
|
|
||
| # General settings | ||
| review: | ||
| # Review tone - professional but friendly | ||
| tone: "professional" | ||
|
|
||
| # Focus on security, performance, and code quality | ||
| focus: | ||
| - "security" | ||
| - "performance" | ||
| - "code_quality" | ||
| - "best_practices" | ||
| - "documentation" | ||
|
|
||
| # Ignore certain files and directories | ||
| ignore: | ||
| paths: | ||
| - "**/*.pyc" | ||
| - "**/__pycache__/**" | ||
| - "**/.pytest_cache/**" | ||
| - "**/node_modules/**" | ||
| - "**/.venv/**" | ||
| - "**/venv/**" | ||
| - "**/data/**" | ||
| - "**/logs/**" | ||
| - "**/*.log" | ||
| - "**/safety-results.json" | ||
| - "**/audit-results.json" | ||
| - "**/.coverage" | ||
| - "**/coverage.xml" | ||
| - "**/dist/**" | ||
| - "**/build/**" | ||
| - "**/.mypy_cache/**" | ||
|
|
||
| # Path-specific instructions | ||
| path_instructions: | ||
| # API and main application code | ||
| - paths: ["src/**/*.py"] | ||
| instructions: | | ||
| Focus on: | ||
| - API design and RESTful principles | ||
| - Error handling and validation | ||
| - Security considerations (input validation, authentication) | ||
| - Performance implications | ||
| - Type hints and documentation | ||
| - FastAPI best practices | ||
|
|
||
| # Client libraries | ||
| - paths: ["clients/**/*"] | ||
| instructions: | | ||
| Focus on: | ||
| - API client design patterns | ||
| - Error handling and retry logic | ||
| - Type safety and interfaces | ||
| - Documentation and examples | ||
| - Cross-platform compatibility | ||
|
|
||
| # CI/CD and workflows | ||
| - paths: [".github/**/*"] | ||
| instructions: | | ||
| Focus on: | ||
| - Security best practices | ||
| - Workflow efficiency | ||
| - Proper permissions and secrets handling | ||
| - Dependabot configuration | ||
| - Security scanning setup | ||
|
|
||
| # Documentation | ||
| - paths: ["*.md", "docs/**/*"] | ||
| instructions: | | ||
| Focus on: | ||
| - Clarity and completeness | ||
| - Up-to-date information | ||
| - Proper markdown formatting | ||
| - Security policy accuracy | ||
| - Contribution guidelines | ||
|
|
||
| # Configuration files | ||
| - paths: ["requirements.txt", "pyproject.toml", "*.yaml", "*.yml"] | ||
| instructions: | | ||
| Focus on: | ||
| - Dependency security and versions | ||
| - Configuration best practices | ||
| - Security implications | ||
| - Proper formatting and structure | ||
|
|
||
| # Review behavior | ||
| behavior: | ||
| # Auto-approve if no issues found and all checks pass | ||
| auto_approve: | ||
| enabled: true | ||
| conditions: | ||
| - "no_security_issues" | ||
| - "no_critical_issues" | ||
| - "ci_passes" | ||
| - "small_change" | ||
|
|
||
| # Create issues for significant problems | ||
| create_issues: | ||
| enabled: true | ||
| threshold: "medium" | ||
|
|
||
| # Security focus | ||
| security: | ||
| # Enhanced security scanning | ||
| enabled: true | ||
| focus: | ||
| - "dependency_vulnerabilities" | ||
| - "secrets_detection" | ||
| - "injection_attacks" | ||
| - "authentication_bypass" | ||
| - "data_exposure" | ||
|
|
||
| # Performance monitoring | ||
| performance: | ||
| enabled: true | ||
| focus: | ||
| - "api_response_times" | ||
| - "memory_usage" | ||
| - "database_queries" | ||
| - "caching_strategies" | ||
|
|
||
| # Integration settings | ||
| integrations: | ||
| # GitHub integration | ||
| github: | ||
| # Comment on PRs | ||
| comment_on_pr: true | ||
|
|
||
| # Create issues for problems | ||
| create_issues: true | ||
|
|
||
| # Suggest changes | ||
| suggest_changes: true | ||
|
|
||
| # Custom review prompts | ||
| custom_prompts: | ||
| - name: "ContextForge Memory Review" | ||
| prompt: | | ||
| You are reviewing code for ContextForge Memory, a lightweight external memory layer. | ||
|
|
||
| Key considerations: | ||
| - This is a memory service with store, search, and embed APIs | ||
| - Security is critical - this handles potentially sensitive data | ||
| - Performance matters - it should be fast and efficient | ||
| - The API should be simple and intuitive | ||
| - Code should be well-documented and maintainable | ||
|
|
||
| Pay special attention to: | ||
| - Input validation and sanitization | ||
| - Error handling and edge cases | ||
| - API design consistency | ||
| - Security vulnerabilities | ||
| - Performance implications | ||
| - Code clarity and documentation | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,4 +15,8 @@ node_modules/ | |
| logs/ | ||
| data/ | ||
|
|
||
| # Security scan artifacts | ||
| safety-results.json | ||
| audit-results.json | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,13 +2,20 @@ | |
|
|
||
| ## Our Pledge | ||
|
|
||
| We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, caste, color, religion, or sexual identity and orientation. | ||
| We as members, contributors, and leaders pledge to make participation in our | ||
| community a harassment-free experience for everyone, regardless of age, body | ||
| size, visible or invisible disability, ethnicity, sex characteristics, gender | ||
| identity and expression, level of experience, education, socio-economic status, | ||
| nationality, personal appearance, race, caste, color, religion, or sexual | ||
| identity and orientation. | ||
|
|
||
| We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community. | ||
| We pledge to act and interact in ways that contribute to an open, welcoming, | ||
| diverse, inclusive, and healthy community. | ||
|
|
||
| ## Our Standards | ||
|
|
||
| Examples of behavior that contributes to a positive environment for our community include: | ||
| Examples of behavior that contributes to a positive environment for our | ||
| community include: | ||
|
|
||
| * Using welcoming and inclusive language | ||
| * Being respectful of differing viewpoints and experiences | ||
|
|
@@ -18,59 +25,102 @@ Examples of behavior that contributes to a positive environment for our communit | |
|
|
||
| Examples of unacceptable behavior include: | ||
|
|
||
| * The use of sexualized language or imagery, and sexual attention or advances of any kind | ||
| * The use of sexualized language or imagery, and sexual attention or advances | ||
| of any kind | ||
| * Trolling, insulting or derogatory comments, and personal or political attacks | ||
| * Public or private harassment | ||
| * Publishing others' private information, such as a physical or email address, without their explicit permission | ||
| * Other conduct which could reasonably be considered inappropriate in a professional setting | ||
| * Publishing others' private information, such as a physical or email address, | ||
| without their explicit permission | ||
| * Other conduct which could reasonably be considered inappropriate in a | ||
| professional setting | ||
|
|
||
| ## Enforcement Responsibilities | ||
|
|
||
| Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful. | ||
| Community leaders are responsible for clarifying and enforcing our standards of | ||
| acceptable behavior and will take appropriate and fair corrective action in | ||
| response to any behavior that they deem inappropriate, threatening, offensive, | ||
| or harmful. | ||
|
|
||
| Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate. | ||
| Community leaders have the right and responsibility to remove, edit, or reject | ||
| comments, commits, code, wiki edits, issues, and other contributions that are | ||
| not aligned to this Code of Conduct, and will communicate reasons for | ||
| moderation decisions when appropriate. | ||
|
|
||
| ## Scope | ||
|
|
||
| This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. | ||
| This Code of Conduct applies within all community spaces, and also applies when | ||
| an individual is officially representing the community in public spaces. | ||
| Examples of representing our community include using an official project e-mail | ||
| address, posting via an official social media account, or acting as an appointed | ||
| representative at an online or offline event. | ||
|
|
||
| ## Enforcement | ||
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at [[email protected]](mailto:[email protected]). All complaints will be reviewed and investigated promptly and fairly. | ||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
| reported to the community leaders responsible for enforcement at | ||
| [[email protected]](mailto:[email protected]). All | ||
| complaints will be reviewed and investigated promptly and fairly. | ||
|
|
||
| All community leaders are obligated to respect the privacy and security of the reporter of any incident. | ||
| All community leaders are obligated to respect the privacy and security of the | ||
| reporter of any incident. | ||
|
|
||
| ## Enforcement Guidelines | ||
|
|
||
| Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct: | ||
| Community leaders will follow these Community Impact Guidelines in determining | ||
| the consequences for any action they deem in violation of this Code of Conduct: | ||
|
|
||
| ### 1. Correction | ||
| **Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community. | ||
|
|
||
| **Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested. | ||
| **Community Impact**: Use of inappropriate language or other behavior deemed | ||
| unprofessional or unwelcome in the community. | ||
|
|
||
| **Consequence**: A private, written warning from community leaders, providing | ||
| clarity around the nature of the violation and an explanation of why the | ||
| behavior was inappropriate. A public apology may be requested. | ||
|
|
||
| ### 2. Warning | ||
|
|
||
| **Community Impact**: A violation through a single incident or series of actions. | ||
|
|
||
| **Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban. | ||
| **Consequence**: A warning with consequences for continued behavior. No | ||
| interaction with the people involved, including unsolicited interaction with | ||
| those enforcing the Code of Conduct, for a specified period of time. This | ||
| includes avoiding interactions in community spaces as well as external channels | ||
| like social media. Violating these terms may lead to a temporary or permanent | ||
| ban. | ||
|
|
||
| ### 3. Temporary Ban | ||
| **Community Impact**: A serious violation of community standards, including sustained inappropriate behavior. | ||
|
|
||
| **Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban. | ||
| **Community Impact**: A serious violation of community standards, including | ||
| sustained inappropriate behavior. | ||
|
|
||
| **Consequence**: A temporary ban from any sort of interaction or public | ||
| communication with the community for a specified period of time. No public or | ||
| private interaction with the people involved, including unsolicited interaction | ||
| with those enforcing the Code of Conduct, is allowed during this period. | ||
| Violating these terms may lead to a permanent ban. | ||
|
|
||
| ### 4. Permanent Ban | ||
| **Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals. | ||
|
|
||
| **Consequence**: A permanent ban from any sort of public interaction within the community. | ||
| **Community Impact**: Demonstrating a pattern of violation of community | ||
| standards, including sustained inappropriate behavior, harassment of an | ||
| individual, or aggression toward or disparagement of classes of individuals. | ||
|
|
||
| **Consequence**: A permanent ban from any sort of public interaction within the | ||
| community. | ||
|
|
||
| ## Attribution | ||
|
|
||
| This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.1, available at [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1]. | ||
| This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
| version 2.1, available at | ||
| [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1]. | ||
|
|
||
| Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder][Mozilla CoC]. | ||
| Community Impact Guidelines were inspired by [Mozilla's code of conduct | ||
| enforcement ladder][Mozilla CoC]. | ||
|
|
||
| For answers to common questions about this code of conduct, see the FAQ at [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at [https://www.contributor-covenant.org/translations][translations]. | ||
| For answers to common questions about this code of conduct, see the FAQ at | ||
| [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at | ||
| [https://www.contributor-covenant.org/translations][translations]. | ||
|
|
||
| [homepage]: https://www.contributor-covenant.org | ||
| [v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.