feat: add CodeRabbit automation improvements and AST-based handlers #38
Conversation
- Replace .eslintrc.js with eslint.config.js (ESLint v9 requirement) - Add 'type': 'module' to package.json for ES module support - Update Jest config to use ES module syntax - Fix rollup configuration for new @rollup/plugin-typescript version - Add proper globals configuration for Node.js and browser APIs - Install globals package for ESLint configuration - All tests and linting now working with new versions Resolves ESLint v9 migration issues from Renovate updates
- Add comment to TypeScript README to trigger CI - Test if ESLint v9 configuration works in CI environment
- Convert CommonJS require() to ES module import syntax - Add __dirname and __filename polyfills for ES modules - Fixes TypeScript client CI failure due to ES module configuration
- Extract duplicated TypeScript rules into sharedTypeScriptRules constant - Replace inline rule objects in both base and test configs with shared constant - Maintains all original rules and configurations unchanged - Improves maintainability by eliminating code duplication - Follows DRY principle for better code organization
- Replace CommonJS require() calls with ES module import statements - Add __dirname and __filename polyfills using fileURLToPath and path.dirname - Import fileURLToPath from 'url' module for ES module compatibility - Maintains all original functionality while using modern ES module syntax - Consistent with prepare.js ES module conversion
- Add eslint-config-prettier to devDependencies in package.json - Import eslint-config-prettier in ESLint configuration - Include prettier config in ESLint config array after js.configs.recommended - Disables Prettier-related ESLint rules to prevent conflicts - Ensures consistent code formatting between ESLint and Prettier - Maintains all existing ESLint rules while preventing style conflicts
- Extract duplicated global declarations into sharedGlobals constant - Include ...globals.node, ...globals.browser and readonly browser APIs - Replace base config globals with sharedGlobals reference - Replace test config globals with sharedGlobals + test-specific additions - Eliminates code duplication while maintaining all original functionality - Improves maintainability by centralizing global declarations
- Update package-lock.json to include eslint-config-prettier dependency - Resolves CI failure where npm ci couldn't install due to lock file mismatch - Ensures package.json and package-lock.json are in sync - Fixes TypeScript Client CI/CD workflow dependency installation
- Remove explicit fetch, setTimeout, clearTimeout declarations from sharedGlobals - These globals are already included in globals.browser - Eliminates duplication and improves maintainability
- Remove .eslintrc.test.js file that was superseded by ESLint v9 flat config - ESLint v9 migration was completed in PR 37 - All ESLint configuration now handled by eslint.config.js
## 🚀 CodeRabbit Automation Improvements This commit adds comprehensive improvements to the CodeRabbit suggestion automation system to prevent structural file issues and provide better handling of JSON, YAML, and TOML files. ### 📋 Changes Made #### **Documentation** - ✅ **automation-improvements.md**: Comprehensive guide for CodeRabbit automation improvements - ✅ **Problem analysis**: Documents the package.json duplication issue and solution - ✅ **Architecture overview**: Explains AST-based transformation approach - ✅ **Implementation guide**: Step-by-step instructions for future improvements #### **AST-Based File Handlers** - ✅ **JSON Handler**: Prevents duplicate keys and validates JSON structure - ✅ **YAML Handler**: Handles YAML files with proper structure validation - ✅ **TOML Handler**: Manages TOML files with semantic validation - ✅ **Modular Design**: Each handler is independent and testable #### **Testing & Validation** - ✅ **test_json_handler.py**: Working test suite for JSON handler functionality - ✅ **Duplicate Prevention**: Validates that duplicate key issues are prevented - ✅ **File Structure**: Ensures proper JSON structure is maintained ### 🎯 Benefits 1. **Prevents File Corruption**: AST-based approach prevents structural issues 2. **Better Error Handling**: Semantic validation catches problems early 3. **Maintainable Code**: Modular handlers are easy to extend and test 4. **Documentation**: Comprehensive guide for future automation improvements ### 🧪 Testing - ✅ JSON handler tests pass - ✅ Duplicate key prevention verified - ✅ File structure validation working - ✅ All imports functional This addresses the package.json duplication issue and provides a robust foundation for future CodeRabbit automation improvements.
- Move test_json_handler.py from root to tests/ directory - Update import path to work from tests/ directory - Remove duplicate pathlib import - Add T20 (print statements) to per-file-ignores for test files - Fix line length issues and unused variables - Remove unnecessary open mode parameters - Break long strings to comply with 88 character limit - Maintain all test functionality and imports This follows proper Python project structure where test files belong in the tests/ directory and allows print statements in test files for demonstration purposes.
📝 WalkthroughWalkthroughThe TypeScript client project is migrated from CommonJS to ES Modules (ESM), with ESLint configuration moved from legacy format to the new flat config standard. Build tools, package manifest, and development scripts are updated to support ESM resolution and module semantics. Python test linting is relaxed to permit print statements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Multiple file categories with consistent ESM conversion patterns across scripts and configs, mixed with tooling configuration changes spanning ESLint, Jest, and build systems. Moderate architectural shift requiring verification of module resolution semantics and config validation, but logic density remains low with repetitive patterns reducing per-file complexity. Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (8)
clients/typescript/README.mdis excluded by!**/*.mdand included byclients/**clients/typescript/package-lock.jsonis excluded by!**/package-lock.jsonand included byclients/**docs/automation-improvements.mdis excluded by!docs/**,!**/*.mdand included by nonescripts/handlers/__init__.pyis excluded by none and included by nonescripts/handlers/json_handler.pyis excluded by none and included by nonescripts/handlers/toml_handler.pyis excluded by none and included by nonescripts/handlers/yaml_handler.pyis excluded by none and included by nonetests/test_json_handler.pyis excluded by none and included by none
📒 Files selected for processing (13)
clients/typescript/.eslintignore(0 hunks)clients/typescript/.eslintrc.js(0 hunks)clients/typescript/.eslintrc.test.js(0 hunks)clients/typescript/eslint.config.js(1 hunks)clients/typescript/jest.config.js(1 hunks)clients/typescript/package.json(2 hunks)clients/typescript/rollup.config.js(1 hunks)clients/typescript/scripts/dev.js(1 hunks)clients/typescript/scripts/prepare.js(1 hunks)clients/typescript/src/index.ts(9 hunks)clients/typescript/tests/contextforgeClient.test.ts(14 hunks)clients/typescript/tests/setup.ts(1 hunks)pyproject.toml(1 hunks)
💤 Files with no reviewable changes (3)
- clients/typescript/.eslintrc.test.js
- clients/typescript/.eslintrc.js
- clients/typescript/.eslintignore
🧰 Additional context used
📓 Path-based instructions (14)
clients/typescript/**
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Update TypeScript client types and examples to match API changes
TypeScript client should use Husky with fast pre-commit checks and smoke-test pre-push workflow
Files:
clients/typescript/jest.config.jsclients/typescript/package.jsonclients/typescript/scripts/dev.jsclients/typescript/tests/contextforgeClient.test.tsclients/typescript/eslint.config.jsclients/typescript/src/index.tsclients/typescript/rollup.config.jsclients/typescript/scripts/prepare.jsclients/typescript/tests/setup.ts
⚙️ CodeRabbit configuration file
clients/typescript/**: Ensure strict typing, accurate DTOs from OpenAPI, consistent error shapes, and robust timeout/retry semantics.
Prefer fetch/axios configurations with sane defaults; avoid throwing ambiguous any-typed errors.
Files:
clients/typescript/jest.config.jsclients/typescript/package.jsonclients/typescript/scripts/dev.jsclients/typescript/tests/contextforgeClient.test.tsclients/typescript/eslint.config.jsclients/typescript/src/index.tsclients/typescript/rollup.config.jsclients/typescript/scripts/prepare.jsclients/typescript/tests/setup.ts
**/*
📄 CodeRabbit inference engine (.cursor/rules/security.mdc)
Avoid committing content matching common secret patterns (e.g., sk-..., AKIA..., ghp_..., password='...')
Files:
clients/typescript/jest.config.jsclients/typescript/package.jsonclients/typescript/scripts/dev.jsclients/typescript/tests/contextforgeClient.test.tsclients/typescript/eslint.config.jsclients/typescript/src/index.tsclients/typescript/rollup.config.jsclients/typescript/scripts/prepare.jspyproject.tomlclients/typescript/tests/setup.ts
clients/**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
clients/**/*: Client libraries should follow sound API client design patterns
Client libraries must implement error handling and retry logic where appropriate
Ensure type safety and clear interfaces in client libraries
Provide documentation and examples for client libraries
Maintain cross-platform compatibility in client libraries
Files:
clients/typescript/jest.config.jsclients/typescript/package.jsonclients/typescript/scripts/dev.jsclients/typescript/tests/contextforgeClient.test.tsclients/typescript/eslint.config.jsclients/typescript/src/index.tsclients/typescript/rollup.config.jsclients/typescript/scripts/prepare.jsclients/typescript/tests/setup.ts
clients/typescript/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Enforce ESLint + Prettier standards in the TypeScript client
Files:
clients/typescript/jest.config.jsclients/typescript/scripts/dev.jsclients/typescript/tests/contextforgeClient.test.tsclients/typescript/eslint.config.jsclients/typescript/src/index.tsclients/typescript/rollup.config.jsclients/typescript/scripts/prepare.jsclients/typescript/tests/setup.ts
clients/typescript/**/package.json
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Bump TypeScript client version in package.json for breaking changes
Files:
clients/typescript/package.json
clients/typescript/package.json
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
package.json should expose proper entry points (main/module/types/exports) and include build/test/lint scripts (rollup, tsc, vitest, eslint)
Files:
clients/typescript/package.json
clients/typescript/**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
clients/typescript/**/*.ts: Use strict typing with interfaces for request/response objects (e.g., MemoryItem, StoreRequest, StoreResponse) and avoid weakly typed functions
Generate DTOs from the OpenAPI spec (e.g., using openapi-typescript) instead of writing manual DTOs to prevent drift
Avoid any; prefer specific types or unknown with type guards for processing API data
Implement a consistent ApiError shape and a base ContextForgeError class for API errors
Use typed exception subclasses (AuthenticationError, ValidationError, RateLimitError) and branch on them explicitly
Map technical error codes to user-friendly messages via a central ERROR_MESSAGES map and a helper (getUserFriendlyMessage)
Implement retry logic with configurable RetryConfig (maxRetries, baseDelay, maxDelay, jitter) and exponential backoff
Only retry on transient conditions (network errors, rate limits, server errors) via a shouldRetry predicate
HTTP client should use fetch with sane defaults: baseUrl, headers, JSON body, timeout via AbortController, and throw on non-OK responses
Use keep-alive/connection pooling where supported (e.g., Connection: keep-alive) to reuse connections
Support request/response interceptors to transform requests and responses centrally
Use zod for runtime validation of requests and responses; throw ValidationError on invalid data
Validate inputs: namespaces (non-empty, <=100, /^[a-zA-Z0-9_-]+$/), text (non-empty, <=65536), items array (1..100)
Code quality: No any types used in the codebase
Code quality: All functions declare explicit return types
Code quality: Timeouts are configured for HTTP requests (e.g., via AbortController)
Code quality: Public types are exported properly (e.g., DTOs, client interfaces)
Files:
clients/typescript/tests/contextforgeClient.test.tsclients/typescript/src/index.tsclients/typescript/tests/setup.ts
clients/typescript/**/*.{test,spec}.ts
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
clients/typescript/**/*.{test,spec}.ts: Write tests using Jest/Vitest conventions; mock fetch; assert request shape and response handling
Provide integration-style tests covering full workflows (store, search) using mocks as needed
Code quality: Retry logic is covered by tests (e.g., verifies attempts, delays, shouldRetry behavior)
Files:
clients/typescript/tests/contextforgeClient.test.ts
clients/typescript/{**/*.test.ts,**/*.test.tsx,**/*.spec.ts,**/*.spec.tsx,**/*.test.js,**/*.test.jsx,**/*.spec.js,**/*.spec.jsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Use Jest tests with a smoke-test subset optimization for the TypeScript client
Files:
clients/typescript/tests/contextforgeClient.test.ts
clients/typescript/rollup.config.js
📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)
Use Rollup to build ESM, CJS, and minified UMD bundles with @rollup/plugin-typescript (declarations off in bundling) and terser for minification
Files:
clients/typescript/rollup.config.js
pyproject.toml
📄 CodeRabbit inference engine (.cursor/rules/cicd.mdc)
Pin Python dependencies with exact versions (==) or constrained ranges in pyproject.toml, including dev extras
pyproject.toml: Configure ruff, mypy (strict), and black (line length 88, target py310) in pyproject.toml as specified
Bump project version in pyproject.toml for breaking changes
pyproject.toml: Ruff configuration must select: E,F,I,B,UP,C4,PIE,SIM,T20,ASYNC,S,RUF,S603,SIM115,RUF006; with specified per-file ignores
Enable mypy plugin pydantic.mypy and override tests.* disallow_untyped_defs=false
Files:
pyproject.toml
**/pyproject.toml
📄 CodeRabbit inference engine (.cursor/rules/security.mdc)
Pin Python dependencies in pyproject.toml (exact versions, ideally with hashes)
Files:
pyproject.toml
{requirements.txt,pyproject.toml,**/*.{yaml,yml}}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
{requirements.txt,pyproject.toml,**/*.{yaml,yml}}: Keep dependencies secure and appropriately versioned in configuration files
Follow configuration best practices in config files
Assess security implications of configuration changes
Ensure proper formatting and structure in configuration files
Files:
pyproject.toml
{pyproject.toml,requirements*.txt,Pipfile*,package*.json,pnpm-lock.yaml,uv.lock}
⚙️ CodeRabbit configuration file
{pyproject.toml,requirements*.txt,Pipfile*,package*.json,pnpm-lock.yaml,uv.lock}: Flag vulnerable or unpinned deps; suggest safer alternatives; check tool configs (ruff, mypy, pytest, coverage).
Files:
pyproject.toml
🧠 Learnings (11)
📓 Common learnings
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-10-23T13:33:13.407Z
Learning: Applies to clients/typescript/**/*.{ts,tsx,js,jsx} : Enforce ESLint + Prettier standards in the TypeScript client
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-23T13:26:37.198Z
Learning: Applies to clients/typescript/** : Update TypeScript client types and examples to match API changes
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-23T13:26:37.198Z
Learning: Applies to clients/typescript/**/package.json : Bump TypeScript client version in package.json for breaking changes
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/package.json : package.json should expose proper entry points (main/module/types/exports) and include build/test/lint scripts (rollup, tsc, vitest, eslint)
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/tsconfig.json : tsconfig.json should enable strict type-checking and production-friendly options (e.g., strict, noImplicitAny, noUnusedLocals, declaration, sourceMap, outDir, rootDir, resolveJsonModule) and exclude tests from build
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/rollup.config.js : Use Rollup to build ESM, CJS, and minified UMD bundles with rollup/plugin-typescript (declarations off in bundling) and terser for minification
📚 Learning: 2025-10-23T13:26:37.198Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-23T13:26:37.198Z
Learning: Applies to clients/typescript/**/package.json : Bump TypeScript client version in package.json for breaking changes
Applied to files:
clients/typescript/package.json
📚 Learning: 2025-10-23T13:26:37.198Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-10-23T13:26:37.198Z
Learning: Applies to clients/typescript/** : Update TypeScript client types and examples to match API changes
Applied to files:
clients/typescript/package.jsonclients/typescript/tests/contextforgeClient.test.tsclients/typescript/src/index.ts
📚 Learning: 2025-10-23T13:31:29.892Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/package.json : package.json should expose proper entry points (main/module/types/exports) and include build/test/lint scripts (rollup, tsc, vitest, eslint)
Applied to files:
clients/typescript/package.json
📚 Learning: 2025-10-23T13:31:29.892Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/**/*.ts : Implement a consistent ApiError shape and a base ContextForgeError class for API errors
Applied to files:
clients/typescript/tests/contextforgeClient.test.ts
📚 Learning: 2025-10-23T13:31:29.892Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/**/*.{test,spec}.ts : Write tests using Jest/Vitest conventions; mock fetch; assert request shape and response handling
Applied to files:
clients/typescript/tests/contextforgeClient.test.tsclients/typescript/tests/setup.ts
📚 Learning: 2025-10-23T13:33:13.407Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-10-23T13:33:13.407Z
Learning: Applies to clients/typescript/**/*.{ts,tsx,js,jsx} : Enforce ESLint + Prettier standards in the TypeScript client
Applied to files:
clients/typescript/eslint.config.js
📚 Learning: 2025-10-23T13:31:29.892Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/rollup.config.js : Use Rollup to build ESM, CJS, and minified UMD bundles with rollup/plugin-typescript (declarations off in bundling) and terser for minification
Applied to files:
clients/typescript/rollup.config.js
📚 Learning: 2025-10-23T13:31:29.892Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/typescript.mdc:0-0
Timestamp: 2025-10-23T13:31:29.892Z
Learning: Applies to clients/typescript/tsconfig.json : tsconfig.json should enable strict type-checking and production-friendly options (e.g., strict, noImplicitAny, noUnusedLocals, declaration, sourceMap, outDir, rootDir, resolveJsonModule) and exclude tests from build
Applied to files:
clients/typescript/rollup.config.js
📚 Learning: 2025-10-23T13:28:42.367Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/python.mdc:0-0
Timestamp: 2025-10-23T13:28:42.367Z
Learning: Applies to pyproject.toml : Ruff configuration must select: E,F,I,B,UP,C4,PIE,SIM,T20,ASYNC,S,RUF,S603,SIM115,RUF006; with specified per-file ignores
Applied to files:
pyproject.toml
📚 Learning: 2025-10-23T13:28:42.367Z
Learnt from: CR
PR: VirtualAgentics/ConextForge_memory#0
File: .cursor/rules/python.mdc:0-0
Timestamp: 2025-10-23T13:28:42.367Z
Learning: Applies to {tests/**/*.py,**/test_*.py,**/*_test.py} : Assert statements are allowed in test files (S101 ignored per configuration)
Applied to files:
pyproject.toml
🧬 Code graph analysis (1)
clients/typescript/tests/contextforgeClient.test.ts (1)
clients/typescript/src/index.ts (1)
ContextForgeClient(88-554)
🔇 Additional comments (10)
clients/typescript/rollup.config.js (1)
44-44: LGTM: Correct use ofdeclarationDirfor TypeScript declarations.The change from
outDirtodeclarationDircorrectly specifies where type declaration files should be emitted, aligning with the package.jsontypesfield pointing todist/types/index.d.ts.pyproject.toml (1)
28-30: Print statements now allowed in test files.The T20 rule relaxation permits print statements in tests, which can aid debugging but may result in verbose test output if not cleaned up. Ensure print statements are intentional and not leftover debug code.
clients/typescript/scripts/prepare.js (1)
8-13: ESM migration correctly implemented.The script properly migrates from CommonJS to ES Modules using the standard pattern with
fileURLToPath(import.meta.url)for path resolution. This aligns with the package.json"type": "module"declaration.clients/typescript/scripts/dev.js (1)
19-25: ESM migration correctly implemented.The script successfully migrates to ES Modules using the standard Node.js pattern with
fileURLToPath(import.meta.url). This is consistent with the prepare.js migration and aligns with the package-level ESM enablement.clients/typescript/package.json (2)
4-4: ESM enabled with correct dual-format support.The
"type": "module"declaration is properly implemented with dual-module support verified: Rollup builds both CJS (format: 'cjs') and ESM (format: 'esm') formats, and theexportsfield correctly routes to both entry points (dist/index.jsfor CJS,dist/index.esm.jsfor ESM). No changes required.
72-73: Version choices are secure.The specified versions are safe and appropriate:
- eslint-config-prettier ^9.1.0 avoids vulnerable 10.1.6+ and 9.1.1 versions
- globals 16.4.0 is the latest stable version with no known vulnerabilities
The caret constraint ensures npm won't select compromised versions while staying compatible with ESLint 9 flat config.
clients/typescript/jest.config.js (1)
1-31: LGTM! Clean ESM migration.The Jest configuration correctly migrates from CommonJS to ES module syntax with
export default, and all ESM-specific settings (preset: 'ts-jest/presets/default-esm',useESM: true,extensionsToTreatAsEsm) are properly configured.clients/typescript/eslint.config.js (3)
1-5: LGTM! Proper ESM imports for flat config.All required ESLint plugins, parsers, and configs are correctly imported using ES module syntax, supporting the migration to flat config format.
8-25: Excellent strict TypeScript rules.The shared rules enforce strong type safety with explicit return types, no
anytypes, and strict boolean expressions. This aligns with the coding guidelines requiring strict typing and clear interfaces in client libraries.As per coding guidelines
47-47: No action required; configuration files are properly set up.Both
tsconfig.jsonandtsconfig.test.jsonexist and are correctly configured. The base configuration enables strict type checking with comprehensive strictness options (noImplicitAny,noUnusedLocals,noUnusedParameters, etc.), and the test configuration properly extends it with Jest types. ESLint's type-aware linting rules will function correctly.
| '*.js', | ||
| '*.mjs', |
There was a problem hiding this comment.
Overly broad ignore pattern excludes all JavaScript files.
The current ignore pattern *.js and *.mjs excludes ALL JavaScript files from linting, including:
- This ESLint config file itself (
eslint.config.js) - Jest configuration (
jest.config.js) - Build scripts (
scripts/dev.js,scripts/prepare.js)
This prevents quality checks on configuration and tooling files that should be linted.
Consider replacing with more specific patterns that only ignore generated/compiled files:
ignores: [
'dist/**',
'node_modules/**',
'coverage/**',
- '*.js',
- '*.mjs',
+ 'dist/**/*.js',
+ 'build/**/*.js',
],Or add a separate configuration block for .js and .mjs files if they should be linted with different rules:
+ {
+ files: ['*.js', '*.mjs', 'scripts/**/*.js'],
+ languageOptions: {
+ ecmaVersion: 2020,
+ sourceType: 'module',
+ globals: sharedGlobals,
+ },
+ rules: {
+ ...js.configs.recommended.rules,
+ 'prefer-const': 'error',
+ 'no-var': 'error',
+ },
+ },
{
ignores: [
'dist/**',
'node_modules/**',
'coverage/**',
- '*.js',
- '*.mjs',
],
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| '*.js', | |
| '*.mjs', | |
| 'dist/**', | |
| 'node_modules/**', | |
| 'coverage/**', | |
| 'dist/**/*.js', | |
| 'build/**/*.js', |
🤖 Prompt for AI Agents
In clients/typescript/eslint.config.js around lines 82-83, the ignore patterns
'*.js' and '*.mjs' are too broad and exclude all JavaScript files (including
config and build scripts); replace those broad patterns with targeted ignores
for generated/compiled artifacts (e.g., dist/**, build/**, coverage/**,
**/*.min.js) and remove the general '*.js'/'*.mjs' entries, or alternatively add
an ESLint override block that explicitly includes and configures linting rules
for .js and .mjs files (so config/tools files are linted while generated outputs
remain ignored).
PR Closed - Replaced by PR #39
This PR has been closed because it had merge conflicts with the main branch. A new clean PR has been created to replace it.
✅ New PR Created:
feat/coderabbit-automation-improvements-v2🔄 What Was Done:
Status: Superseded by PR #39 - All functionality preserved with clean implementation.