Skip to content

Conversation

@Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Oct 15, 2025

Following up on #3911

  • the config module will no longer be cross-compiled for Scala 2, nor will it target Java 8 (cc @alexarchambault)
  • similarly, specification-level no longer needs Scala 2 cross-compilation
  • removed some Scala-2-specific hacks which are no longer needed as a result
  • bumped jsoniter-scala from an antique 2.13.5.2 version (which we kept cuz it still supported Java 8) to 2.38.2
    • this actually fixes the JSON export to respect the format we have in our docs (I adjusted the tests, which assumed a different format)

Requires

@Gedochao Gedochao force-pushed the maintenance/scala-2-cleanup-sequel branch 4 times, most recently from d078f65 to c44ec6d Compare October 15, 2025 15:15
@Gedochao Gedochao changed the title Drop Scala 2 in config and specification-level modules Drop Scala 2 in config and specification-level modules & bump jsoniter-scala to 2.38.2 (was 2.13.5.2) Oct 15, 2025
@Gedochao Gedochao force-pushed the maintenance/scala-2-cleanup-sequel branch 2 times, most recently from 01f494b to 6834fd4 Compare October 16, 2025 08:46
@Gedochao Gedochao force-pushed the maintenance/scala-2-cleanup-sequel branch from 6834fd4 to 3640719 Compare October 16, 2025 09:23
@Gedochao Gedochao requested a review from tgodzik October 16, 2025 09:27
@Gedochao Gedochao marked this pull request as ready for review October 16, 2025 09:27
@Gedochao Gedochao requested a review from zielinsky October 16, 2025 09:27
@Gedochao Gedochao enabled auto-merge October 16, 2025 10:56
@Gedochao Gedochao merged commit 916a4c8 into VirtusLab:main Oct 16, 2025
98 of 106 checks passed
@Gedochao Gedochao deleted the maintenance/scala-2-cleanup-sequel branch October 16, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants