Skip to content

fix: avoid crash on Windows when passing invalid file to compile function #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plusvic merged 1 commit into from
Mar 12, 2025
Merged

fix: avoid crash on Windows when passing invalid file to compile function #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions yara-python.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2816,12 +2816,12 @@ static PyObject* yara_compile(
}
else if (file != NULL)
{
fd = dup(PyObject_AsFileDescriptor(file));
fd = PyObject_AsFileDescriptor(file);

if (fd != -1)
{
Py_BEGIN_ALLOW_THREADS
fh = fdopen(fd, "r");
fh = fdopen(dup(fd), "r");
error = yr_compiler_add_file(compiler, fh, NULL, NULL);
fclose(fh);
Py_END_ALLOW_THREADS
Expand Down
Loading