feat(ls): recognize identifiers declared in with and for statements#560
Merged
plusvic merged 8 commits intoVirusTotal:mainfrom Feb 16, 2026
Merged
feat(ls): recognize identifiers declared in with and for statements#560plusvic merged 8 commits intoVirusTotal:mainfrom
with and for statements#560plusvic merged 8 commits intoVirusTotal:mainfrom
Conversation
…ithin various LSP features This includes: - Code Completion - Document Highlight - Find References - Rename - Hover - Go to definition
… and `with`/`for` identifiers
…y_with` and `identifiers_declared_by_for`. Also renamed some other functions and set names easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the following LSP language features, that from now can recognize identifiers declared in
withandforstatements:Code CompletionFind referencesRenameGo to definitionHoverDocument HighlightThere was also a bug within
Find References,Document HighlightandRenamefeatures. When these features were used on the rule identifier, the same identifiers withinwithandforstatements were also affected. This was fixed by doing some code changes incst_traversalmodule, which are included in this PR.Maybe it is the wrong PR to fix it, but I've also noticed that all of the
Document Highlighttests were in fact testing nothing, because there were invalid file names(documenthighlightsN.yarinstead ofhighlightsN.yar). I hope now the testing is performed correctly.Thanks.