Skip to content

fix: not update layout when scrollbar domain is the same as before. f… #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xile611 merged 1 commit into from
Dec 2, 2024
Merged

fix: not update layout when scrollbar domain is the same as before. f… #3478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vchart/fix-scollbar-domain-cache_2024-11-29-10-56.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: not update layout when scrollbar domain is the same as before. fix#3452",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
5 changes: 4 additions & 1 deletion packages/vchart/src/component/data-zoom/data-filter-base-component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ export abstract class DataFilterBaseComponent<T extends IDataFilterComponentSpec
protected _spanCache!: number;
protected _shouldChange: boolean = true;

protected _domainCache!: any;

protected _field!: string | undefined;
protected _stateField: string = 'x';
protected _valueField?: string;
Expand Down Expand Up @@ -404,7 +406,8 @@ export abstract class DataFilterBaseComponent<T extends IDataFilterComponentSpec
this._stateScale.domain(domain, false);
this._handleChange(this._start, this._end, true);
// auto 模式下需要重新布局
if (this._spec.auto) {
if (this._spec.auto && !isEqual(this._domainCache, domain)) {
this._domainCache = domain;
this._dataUpdating = true;
this.getChart()?.setLayoutTag(true, null, false);
}
Expand Down