Skip to content

Conversation

@Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Dec 7, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the vchart label Dec 7, 2024
@xile611
Copy link
Contributor

xile611 commented Dec 9, 2024

@Kingwl 感谢参与VChart 开源代码贡献;
看到你这里提交的代码,这个功能现在应该也是可以支持的:

https://www.visactor.io/vchart/option/barChart#tooltip.dimension.updateContent

比如通过 updateContent 进行过滤,不知道你之前调研过吗

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 9, 2024

@xile611 你好 这里面有俩功能 一个是 filterMode 一个是 filterRange as function.不知道你说的是哪个。。

@xile611
Copy link
Contributor

xile611 commented Dec 9, 2024

@xile611 你好 这里面有俩功能 一个是 filterMode 一个是 filterRange as function.不知道你说的是哪个。。

filterRange 接收 function 没问题,已经合并了
filterMode 有点没必要,因为有回调函数支持相同的功能,不建议额外增加配置了

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 9, 2024

filterMode 这个其实有点奇怪
最早的支持 tooltipFilterRange 其实包含了两个改动(但只有一个选项来控制): 1. 从值里面筛data 2. 单选变多选
从API的一致性和正交性考虑 可能还是需要一个 filterMode?

@xile611
Copy link
Contributor

xile611 commented Dec 9, 2024

@Kingwl 如果功能通过现有配置能够支持的话,我们不建议新增配置,这样配置规模膨胀的太厉害了

另一个角度 filterMode 的话,可能对其他一些复杂的过滤场景还是满足不了,所以我们还是建议通过 updateContent 来实现

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 9, 2024

我没啥意见。。。

@xile611
Copy link
Contributor

xile611 commented Dec 9, 2024

我没啥意见。。。

那这个PR我暂时关掉了哈,另一个PR已经合并了

后面我们季度总结,贡献者应该都有礼品的哈,到时候联系你哈

也欢迎继续参与其他PR贡献

@xile611 xile611 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants