Skip to content

fix(gantt): correct month difference calculation for variable month lengths #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n313893254 wants to merge 1 commit into
base: develop
Choose a base branch
from
+8 −3
Open

fix(gantt): correct month difference calculation for variable month lengths #4909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/vtable-gantt/src/tools/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,10 @@ export function computeCountToTimeScale(

let difference: number;
const adjusted_date = new Date(date.getTime() + diffMS);

const startDaysInMonth = new Date(startDate.getFullYear(), startDate.getMonth() + 1, 0).getDate();
const adjustedDaysInMonth = new Date(adjusted_date.getFullYear(), adjusted_date.getMonth() + 1, 0).getDate();

switch (timeScale) {
case 'second':
difference = (adjusted_date.getTime() - startDate.getTime()) / msInSecond;
Expand All @@ -697,9 +701,10 @@ export function computeCountToTimeScale(
difference =
(adjusted_date.getFullYear() - startDate.getFullYear()) * 12 +
(adjusted_date.getMonth() - startDate.getMonth());
difference +=
(adjusted_date.getDate() - startDate.getDate()) /
new Date(adjusted_date.getFullYear(), adjusted_date.getMonth() + 1, 0).getDate();

// Calculate fractional difference by normalizing day progress within each specific month
// This handles variable month lengths (28/29/30/31 days) correctly
difference += adjusted_date.getDate() / adjustedDaysInMonth - startDate.getDate() / startDaysInMonth;
break;
case 'quarter':
difference =
Expand Down