Skip to content

Fix/gantt time scale count #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fangsmile wants to merge 4 commits into
base: develop
Choose a base branch
from
+18 −3
Open

Fix/gantt time scale count #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0405152
fix(gantt): correct month difference calculation for variable month l…
n313893254 Jan 9, 2026
f4b45e5
Merge pull request #4916 from n313893254/develop
fangsmile Jan 13, 2026
920eb8b
fix: time unit computeCountToTimeScale month exactitude #4909
fangsmile Jan 13, 2026
0741294
docs: update changlog of rush
fangsmile Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vtable/fix-gantt-time-scaleCount_2026-01-13-09-13.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: time unit computeCountToTimeScale month exactitude #4909\n\n",
"type": "none",
"packageName": "@visactor/vtable"
}
],
"packageName": "@visactor/vtable",
"email": "[email protected]"
}
10 changes: 7 additions & 3 deletions packages/vtable-gantt/src/tools/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ export function computeCountToTimeScale(

let difference: number;
const adjusted_date = new Date(date.getTime() + diffMS);

switch (timeScale) {
case 'second':
difference = (adjusted_date.getTime() - startDate.getTime()) / msInSecond;
Expand All @@ -694,12 +695,15 @@ export function computeCountToTimeScale(
difference = (adjusted_date.getTime() - startDate.getTime()) / msInWeek;
break;
case 'month':
const startDaysInMonth = new Date(startDate.getFullYear(), startDate.getMonth() + 1, 0).getDate();
const adjustedDaysInMonth = new Date(adjusted_date.getFullYear(), adjusted_date.getMonth() + 1, 0).getDate();
difference =
(adjusted_date.getFullYear() - startDate.getFullYear()) * 12 +
(adjusted_date.getMonth() - startDate.getMonth());
difference +=
(adjusted_date.getDate() - startDate.getDate()) /
new Date(adjusted_date.getFullYear(), adjusted_date.getMonth() + 1, 0).getDate();

// Calculate fractional difference by normalizing day progress within each specific month
// This handles variable month lengths (28/29/30/31 days) correctly
difference += adjusted_date.getDate() / adjustedDaysInMonth - startDate.getDate() / startDaysInMonth;
break;
case 'quarter':
difference =
Expand Down
Loading