Skip to content

Added Clear All feature in favorites#147

Merged
VishnuSanal merged 3 commits intoVishnuSanal:masterfrom
mohanvamsi06:master
Feb 25, 2025
Merged

Added Clear All feature in favorites#147
VishnuSanal merged 3 commits intoVishnuSanal:masterfrom
mohanvamsi06:master

Conversation

@mohanvamsi06
Copy link
Contributor

PR Info

Issue Details

Tests

  • ./gradlew spotlessCheck
  • ./gradlew testDebug

Type of change

  • New Feature

Additional Info

Added a simple button to clear all favorites.

Screenshot from 2025-02-14 23-25-48

@mohanvamsi06
Copy link
Contributor Author

Feedback appreciated, This is my first time trying to contribute in opensource! Thanks.

@VishnuSanal
Copy link
Owner

thanks for your PR, I will take a look and give a review soon :)

@VishnuSanal
Copy link
Owner

Screenshot from 2025-02-14 23-25-48

hi @mohanvamsi06, the functionality works perfectly, but the UI feels a lil out of place. I think changing the button to an imagebutton with icon "round_clear_all_24" (you can use the vector import from android studio) and placing it to the right of favCountTV would be better. what do you think?

Copy link
Owner

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will review the code once the UI changes are made.

@mohanvamsi06
Copy link
Contributor Author

Sure, Will work on it.

@mohanvamsi06 mohanvamsi06 marked this pull request as draft February 19, 2025 17:33
@mohanvamsi06
Copy link
Contributor Author

@VishnuSanal Hey, Made the change as you said, Let me know if anything else is required

Screenshot from 2025-02-21 19-37-10

@mohanvamsi06 mohanvamsi06 marked this pull request as ready for review February 21, 2025 14:15
Copy link
Owner

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mohanvamsi06, the PR looks great. I have some slight changes; please address them & we are good to go. 🚀

@mohanvamsi06
Copy link
Contributor Author

@VishnuSanal Hi, I made the changes you requested four days ago, let me know if anything more is required

@VishnuSanal
Copy link
Owner

@mohanvamsi06 Yep, sure, I was AFK, hence the delay. Will take a look later today & get back to you.

Copy link
Owner

@VishnuSanal VishnuSanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 thanks for your contribution! :)

@VishnuSanal VishnuSanal merged commit a81f67f into VishnuSanal:master Feb 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants