Added Clear All feature in favorites#147
Added Clear All feature in favorites#147VishnuSanal merged 3 commits intoVishnuSanal:masterfrom mohanvamsi06:master
Conversation
|
Feedback appreciated, This is my first time trying to contribute in opensource! Thanks. |
|
thanks for your PR, I will take a look and give a review soon :) |
|
hi @mohanvamsi06, the functionality works perfectly, but the UI feels a lil out of place. I think changing the button to an imagebutton with icon "round_clear_all_24" (you can use the vector import from android studio) and placing it to the right of |
VishnuSanal
left a comment
There was a problem hiding this comment.
will review the code once the UI changes are made.
|
Sure, Will work on it. |
|
@VishnuSanal Hey, Made the change as you said, Let me know if anything else is required |
VishnuSanal
left a comment
There was a problem hiding this comment.
hi @mohanvamsi06, the PR looks great. I have some slight changes; please address them & we are good to go. 🚀
|
@VishnuSanal Hi, I made the changes you requested four days ago, let me know if anything more is required |
|
@mohanvamsi06 Yep, sure, I was AFK, hence the delay. Will take a look later today & get back to you. |
VishnuSanal
left a comment
There was a problem hiding this comment.
LGTM 🚀 thanks for your contribution! :)


PR Info
Issue Details
Tests
./gradlew spotlessCheck./gradlew testDebugType of change
Additional Info
Added a simple button to clear all favorites.