Feature: add ldap support #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitschSB
force-pushed
the
feature/ldap
branch
from
abf53bb to
4c7e99a
Compare
Contributor
Author
|
I don't know why the ldap test fails. I worked once on github and always on my machine. Without the docker compose logs I don't know what to do |
nitschSB
force-pushed
the
feature/ldap
branch
from
8dcc3df to
6f4c0ca
Compare
nitschSB
force-pushed
the
feature/ldap
branch
2 times, most recently
from
d1b42c4 to
9392f5d
Compare
nitschSB
force-pushed
the
feature/ldap
branch
from
9392f5d to
5e4206d
Compare
Contributor
Author
|
My PR finally passed all checks 🥳 ! Maybe you want to look at it now. |
Member
|
@nitschSB well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LDAP support for login.
Everytime a new valid users from LDAP logs in, a new vrt-user gets created and stored the database. The password stored in the database is randomly generated and not used during login.
New user creation via the VRT-UI is declined.
I did my best to adopt the factory pattern, like you did for storage.
I also added a e2e with ldap test to the .github/workflow.yml pipeline.
Looking forward to see a merge soon ;)
Cheers
Mario
This is the same as #294 - I forgot that I have the right to create new branches. The pipeline didn't work in my fork (SonarCloud Scan).
resolves Visual-Regression-Tracker/#324