Skip to content

Added 'Comment' property to CreateTestRequestDto #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Added 'Comment' property to CreateTestRequestDto #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions VisualRegressionTracker/Api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@
"buildId": {
"type": "string"
},
"comment": {
"type": "string"
},
"projectId": {
"type": "string"
},
Expand Down
8 changes: 6 additions & 2 deletions VisualRegressionTracker/VisualRegressionTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ public async Task<TestRunResult> Track(
string device = null,
string customTags = null,
double? diffTollerancePercent = null,
string comment = null,
IEnumerable<IgnoreAreaDto> ignoreAreas = null)
{
var dto = new CreateTestRequestDto
Expand All @@ -198,6 +199,7 @@ public async Task<TestRunResult> Track(
Viewport = viewport,
Device = device,
CustomTags = customTags,
Comment = comment,
DiffTollerancePercent = diffTollerancePercent ?? 0,
IgnoreAreas = ignoreAreas == null ? null : new List<IgnoreAreaDto>(ignoreAreas)
};
Expand Down Expand Up @@ -232,6 +234,7 @@ public Task<TestRunResult> Track(
string device = null,
string customTags = null,
double? diffTollerancePercent = null,
string comment = null,
IEnumerable<IgnoreAreaDto> ignoreAreas = null)
{
using var base64Stream = new CryptoStream(image, new ToBase64Transform(), CryptoStreamMode.Read);
Expand All @@ -242,7 +245,7 @@ public Task<TestRunResult> Track(
name,
imageBase64,
cancellationToken,
os, browser, viewport, device, customTags, diffTollerancePercent, ignoreAreas
os, browser, viewport, device, customTags, diffTollerancePercent, comment, ignoreAreas
);
}

Expand All @@ -256,6 +259,7 @@ public Task<TestRunResult> Track(
string device = null,
string customTags = null,
double? diffTollerancePercent = null,
string comment = null,
IEnumerable<IgnoreAreaDto> ignoreAreas = null)
{
using var memoryStream = new MemoryStream(image);
Expand All @@ -264,7 +268,7 @@ public Task<TestRunResult> Track(
name,
memoryStream,
cancellationToken,
os, browser, viewport, device, customTags, diffTollerancePercent, ignoreAreas
os, browser, viewport, device, customTags, diffTollerancePercent, comment, ignoreAreas
);
}
}
Expand Down
2 changes: 2 additions & 0 deletions tests/VisualRegressionTracker.Tests/VisualRegressionTrackerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ public async Task Track()
Device = "device",
CustomTags = "customTags",
DiffTollerancePercent = 15,
Comment = "testcomment",
IgnoreAreas = new []
{
new IgnoreAreaDto{X=1, Y=2, Width=3, Height=4}
Expand All @@ -270,6 +271,7 @@ public async Task Track()
device: "device",
customTags: "customTags",
diffTollerancePercent: 15,
comment: "testcomment",
ignoreAreas: new[]
{
new IgnoreAreaDto{X=1, Y=2, Width=3, Height=4}
Expand Down
Loading