Skip to content

Make VisualScriptingGamelogicEngine.OnInit asynchronous #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Make VisualScriptingGamelogicEngine.OnInit asynchronous #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20fc06e
Make VisualScriptingGamelogicEngine.OnInit asynchronous
arthurkehrwald Jan 16, 2025
906792d
Fix syntax error
arthurkehrwald Jan 22, 2025
dc4b650
Accept cancellation token in OnInit
arthurkehrwald Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Runtime/Gamelogic/VisualScriptingGamelogicEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
using Unity.VisualScripting;
using UnityEngine;
using VisualPinball.Engine.Game.Engines;
using System.Threading.Tasks;
using System.Threading;

namespace VisualPinball.Unity.VisualScripting
{
Expand Down Expand Up @@ -141,7 +143,7 @@ public void DestroyPlayerStates()
_currentPlayer = 0;
}

public void OnInit(Player player, TableApi tableApi, BallManager ballManager)
public Task OnInit(Player player, TableApi tableApi, BallManager ballManager, CancellationToken ct)
{
_player = player;
BallManager = ballManager;
Expand All @@ -155,6 +157,8 @@ public void OnInit(Player player, TableApi tableApi, BallManager ballManager)
}
OnStarted?.Invoke(this, EventArgs.Empty);
EventBus.Trigger(VisualScriptingEventNames.GleStartedEvent, EventArgs.Empty);

return Task.CompletedTask;
}

public void DisplayClear(string id)
Expand Down