Make a copy of vita3k.log to custom pref-path#607
Open
ikhoeyZX wants to merge 6 commits intoVita3K:androidfrom
Open
Make a copy of vita3k.log to custom pref-path#607ikhoeyZX wants to merge 6 commits intoVita3K:androidfrom
ikhoeyZX wants to merge 6 commits intoVita3K:androidfrom
Conversation
Copy vita3k.log to custom pref-path for easy to share log in Android 14 or newer. log will created if log level not off and it will copy after 2nd run app (it will copy after start app)
vita3k/app/src/app_init.cpp
Outdated
|
|
||
| LOG_INFO("Base path: {}", state.base_path); | ||
| #if defined(__linux__) && !defined(__ANDROID__) && !defined(__APPLE__) | ||
| /* LOG_INFO("Base path: {}", state.base_path); |
Contributor
There was a problem hiding this comment.
vita3k guidelines say to just remove code that has been commented out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's just do a simple copy paste vita3k.log to custom pref-path for easy share log in Android 14 or newer.
log will created if log level not 'off' and it will copy after 2nd time run app (it will copy after start app)
logs are stored at : "[user pref-path]/logs/"
*need merge sdcard support for this