Skip to content

Conversation

@mn7216
Copy link
Contributor

@mn7216 mn7216 commented Mar 16, 2025

Add icons for nicolog.jp, newgrounds.com, distrokid.com, misskey.io, uta.573.jp, joox.com, and audiostock.jp. (I believe I did everything right, tested on beta site)

@FinnRG
Copy link
Member

FinnRG commented Mar 24, 2025

The commit on the ExtIcons submodule in your update doesn't seem to exist according to github.Could you take a look at this?

@Calamitish
Copy link
Contributor

I've tried making a pull request to add the icon for bsky.app and have run into a similar issue where I'm unable to push any commits to the ExtIcons submodule. unable to access 403. There also seems to be a persistent issue locally regarding the aliceBooks.png / AliceBooks.png file. See attached image. Might be an issue related to attempting to work from Windows.
image

@Tonamu
Copy link
Contributor

Tonamu commented Apr 24, 2025

@Calamitish the cause of the issue may be that you are trying to modify information included in the ExtIcons repository through the vocadb repository. Making pull requests directly to the ExtIcons repository could probably solve the problem. Also, an icon for the bluesky already exists (appropriately named bluesky.png), but it seemingly just hasn't been matched correctly. The icon has been matched in the ExtLink.less, but hasn't been matched in the ExtLinks.css, so maybe matching the icon with the URL(s) in the ExtLinks.css could do the trick. To be honest, I have no idea what the function of the ExtLink.less currently is (seems to be something of a replica of ExtLinks.css), but it doesn't seem to work matching the icons with the URL(s) as well as the ExtLinks.css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants