Add more YouTube link matchers #2082
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I also haven't added any unit tests since it seems that it is not required (I only see Bilibili) for some reason, and I also haven't set up VocaDB here. I may could use the AppVeyor CI to test it, but it may need some time, so please tell me whether this is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more YouTube link matchers that works on YouTube.
/shorts/: different GUI (YouTube Shorts) (resolves Multiple entries: Add support for YouTube Short URLs #2072)/watch/: works (loads video likewatch?v=), but updates URL towatch?v=after finished loading/video/: redirects towatch?v=(similar toyoutu.be)Important
This change is untested as setting up VocaDB is a chore that I couldn't handle for now, but changes are made based on existing codebase, so it should be fine.