fix icon cache behavior breaking sw updates#117
Merged
Conversation
a-type
added a commit
that referenced
this pull request
Apr 10, 2025
* fix icon cache behavior breaking sw updates * icon fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever we updated the app build, icon files got new hashes.
Since there are tons of icons and we only use ~10 of them, I had removed icons from the service worker precache (where all other app assets are).
This meant when the app was updated, the icon file paths in the old cached app version were attempted to resolve against remote files which no longer existed, due to the updated hash in the new build. So icons failed to import at all, breaking the app.
This removes the hash from icon filenames, so they should be resolveable in remote even if they weren't cached.
It also adds an on-demand caching of icon files as they are fetched, so that any icon used in the app should make it into the cache after first use.
Finally, adding a fallback for Icon to avoid a missing icon breaking the whole app.