Use Enums for WeekStart

[ChronosMasterOfAllTime]

Describe your changes

Added a weekday enum to pass into the Vue date picker prop instead of a non-descript int/string (0-6).

Issue ticket number and link

Checklist before requesting a review

• I have performed a self-review of my code
• I have ensured that unit tests pass without errors
• If it is a new feature, I have added a new unit test

[Faq]

I'd say better to use config to set start of the week Monday or Sunday

[ChronosMasterOfAllTime]

I'd say better to use config to set start of the week Monday or Sunday

Not sure what you mean. Can you please elaborate @Faq ?

[Faq]

I mean this should be configurable option, where let's say by default week starts at Monday, but with configuration can set that it starts at Sunday.

[Jasenkoo]

It is a personal preference, introducing this change is a breaking change. Also, changing starting day is easy with passing week-start prop

[ChronosMasterOfAllTime]

@Jasenkoo not sure why this was closed. This commit changed the behavior of the calendar to Mon-Sun since weekStart is default 1. Your original code had the days indexed [1,2,3,4,5,6,7] => sun-sat

This PR was to reset and introduce a friendly enum type and go back to the original default start. I verified it locally by running back through the commit history.

Before a32ba3f

After a32ba3f

With this PR:

Plus you can use the enum values to more reliably manipulate the week start and it's non-breaking to existing users. With commit a32ba3f every instance of vue-datepicker I have to now set :week-start="0" <-- this doesn't translate well for DevX.

See Schedule-x for example. They use an enum for setting the first day of the week.

[Jasenkoo]

I am willing to accept the PR, but with applied changes from review

[ChronosMasterOfAllTime]

Will push the changes once GitHub comes back:

[ChronosMasterOfAllTime]

I am willing to accept the PR, but with applied changes from review

Resolved