fix: restore dp-input model binding for formats with MMM/MMMM tokens#1240
Open
kouts wants to merge 1 commit intoVuepic:mainfrom
Open
fix: restore dp-input model binding for formats with MMM/MMMM tokens#1240kouts wants to merge 1 commit intoVuepic:mainfrom
kouts wants to merge 1 commit intoVuepic:mainfrom
Conversation
|
Awesome fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes a regression introduced in v12.1.0 where using the
dp-inputslot with formats containing alphabetic tokens (likeMMMfor month abbreviation) no longer updates the model value.Root cause: The
getPatternForValuefunction (added in commit572c401to fix #1208) used/\D+/gto split input values. This incorrectly treated alphabetic parts like "Dec" in18-Dec-2025as separators instead of date values.Solution: Simplified the parsing logic by:
getPatternForValueandhasAlphabeticTokensfunctionsAdditional improvements:
useTextInputUtils.tsfor better testabilitytryParseDate,parseDateWithPattern,createMaskedValue, andapplyMaxValuesTested scenarios:
dd-MMM-yyyyformat (e.g.,18-Dec-2025) → Model updates correctly ✅dd-MM-yyshort year format (e.g.,18-12-25) → Still works ✅Issue ticket number and link
Fixes #1222
Checklist before requesting a review