Skip to content

Conversation

@miuponn
Copy link

@miuponn miuponn commented May 29, 2025

Fixes #673

Previously hardcoded client version in pom.xml generation is replaced with configurable version at build time or via env in Dockerfile.

Adds support for the following environment variables and build args:

  • INFINISPAN_CLIENT_VERSION: Set the base version of the client
  • USE_LATEST_COMPATIBLE: If true, script uses latest compatible version using versions:use-latest-releases

@CLAassistant
Copy link

CLAassistant commented May 29, 2025

CLA assistant check
All committers have signed the CLA.

@leochr
Copy link
Member

leochr commented Jun 9, 2025

@miuponn Thank you for the PR. Please sign the CLA (see above comment for further information). Also, it's good to sign the commits.

@leochr
Copy link
Member

leochr commented Jun 9, 2025

@idlewis As you had raised this issue, please review the PR as well. Thank you

@leochr leochr requested a review from idlewis June 9, 2025 19:16
Copy link
Member

@idlewis idlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Does this also need to go in 25.0.0.5 (as well as latest)?
Do we also need update our docs?

@leochr
Copy link
Member

leochr commented Jun 17, 2025

Thank you for the review, Iain. 25.0.0.6 will be released today (and 25.0.0.5 will be removed from support). Let's target this for 25.0.0.7, in which case, making the changes only to latest would be sufficient.

@leochr
Copy link
Member

leochr commented Jun 17, 2025

Please hold off merging as the vNext changes for 25.0.0.6 haven't been merged yet into the main branch. I'll merge when ready.

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miuponn As we discussed, added a couple of comments. Thank you

set -Eeox pipefail

INFINISPAN_CLIENT_VERSION=${INFINISPAN_CLIENT_VERSION:-10.1.3.Final}
USE_LATEST_COMPATIBLE=${USE_LATEST_COMPATIBLE:-false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this flag is specific to Infinispan, suggest using INFINISPAN_ as the prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants