-
Notifications
You must be signed in to change notification settings - Fork 62
fix(wiki): updated mods wiki site #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request restructures the definitions of tradable item types. In the Changes
Sequence Diagram(s):Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
build/tradable.mjs(1 hunks)build/wikia/scrapers/ModScraper.mjs(1 hunks)
🧰 Additional context used
🪛 ESLint
build/tradable.mjs
[error] 20-29: Replace ⏎··'Arcane',⏎··'Captura',⏎··'Cut·Gem',⏎··'Fish',⏎··'Focus·Lens',⏎··'Relic',⏎··'Upgrades',⏎··...tradableMods,⏎ with 'Arcane',·'Captura',·'Cut·Gem',·'Fish',·'Focus·Lens',·'Relic',·'Upgrades',·...tradableMods
(prettier/prettier)
🪛 GitHub Check: Lint
build/tradable.mjs
[failure] 20-20:
Replace ⏎··'Arcane',⏎··'Captura',⏎··'Cut·Gem',⏎··'Fish',⏎··'Focus·Lens',⏎··'Relic',⏎··'Upgrades',⏎··...tradableMods,⏎ with 'Arcane',·'Captura',·'Cut·Gem',·'Fish',·'Focus·Lens',·'Relic',·'Upgrades',·...tradableMods
🪛 GitHub Actions: Pull Request Checks
build/tradable.mjs
[error] 20-20: Replace ⏎··'Arcane',⏎··'Captura',⏎··'Cut·Gem',⏎··'Fish',⏎··'Focus·Lens',⏎··'Relic',⏎··'Upgrades',⏎...tradableMods,⏎ with 'Arcane',·'Captura',·'Cut·Gem',·'Fish',·'Focus·Lens',·'Relic',·'Upgrades',·...tradableMods prettier/prettier
🔇 Additional comments (2)
build/wikia/scrapers/ModScraper.mjs (1)
6-6: URL update looks goodThe URL change from fandom.com to wiki.warframe.com is appropriate and aligns with the PR objective of fixing the update path for mods. The Warframe Wiki has likely moved from the Fandom domain to its own domain, so this change is necessary to ensure the mod data is scraped from the correct source.
build/tradable.mjs (1)
4-19: Good separation of mod types into dedicated arrayCreating a separate
tradableModsarray for mod-specific types improves code organization and maintainability. This approach makes it easier to update just the mod types if needed in the future.
|
🎉 This PR is included in version 1.1267.73 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
fix missed mods update path
Reproduction steps
Evidence/screenshot/link to line
Considerations
Summary by CodeRabbit