Skip to content

Conversation

@TobiTenno
Copy link
Member

@TobiTenno TobiTenno commented Nov 29, 2025

What did you fix?

try tailscale again


Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? [Yes/No]
  • Does this introduce opinionated data formatting or manual data entry? [Yes/No]
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [Yes/No]
  • Have I run the linter? [Yes/No]
  • Is is a bug fix, feature request, or enhancement? [Bug Fix/Feature/Enhancement/Docs/Maintenance]

Summary by CodeRabbit

  • Chores

    • Updated CI/build pipeline infrastructure for improved deployment reliability.
  • Bug Fixes

    • Build process now gracefully handles missing proxy configuration instead of failing, enabling broader deployment scenarios.

✏️ Tip: You can customize this high-level summary in your review settings.

@TobiTenno TobiTenno requested a review from a team as a code owner November 29, 2025 06:46
@coderabbitai
Copy link

coderabbitai bot commented Nov 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CI workflows replace WireGuard setup with Tailscale (using OAuth credentials) and add PROXY_URL environment variable. build/scraper.js updated to issue a warning instead of fatal exit when PROXY_URL is missing, with early return for direct fetches when proxy is unconfigured.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/build.yaml, .github/workflows/static.yaml
Replaced WireGuard setup step with Tailscale setup (tailscale/github-action@v4) using OAuth credentials (oauth-client-id, oauth-secret) and tag ci. Added PROXY_URL environment variable to npm build step.
Build Script Proxy Handling
build/scraper.js
Changed PROXY_URL missing condition from fatal exit to non-fatal warning. Added early return for direct fetches when proxy is unconfigured. Updated error message for pagination page determination to reflect proxy requirement.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify Tailscale OAuth configuration correctness across both workflows
  • Confirm PROXY_URL environment variable is properly injected and propagated
  • Test scraper.js logic for graceful fallback to direct fetch when proxy is unavailable
  • Ensure warning message for missing proxy is appropriate and doesn't mask legitimate issues

Possibly related PRs

Suggested reviewers

  • SlayerOrnstein

Poem

🐰 Hop, skip, and TailScale we go! / WireGuard fades like falling snow, / OAuth glows with safe cred cheer, / Proxy routes both far and near, / Direct paths when proxies flee— / Resilience builds so naturally! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch try-again

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a5452b and b698033.

📒 Files selected for processing (3)
  • .github/workflows/build.yaml (1 hunks)
  • .github/workflows/static.yaml (1 hunks)
  • build/scraper.js (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TobiTenno TobiTenno merged commit dabecc5 into master Nov 29, 2025
5 of 6 checks passed
@TobiTenno TobiTenno deleted the try-again branch November 29, 2025 06:47
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 2.88.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants