New Crowdin updates #753
New Crowdin updates #753
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
WalkthroughAdds many new localization entries across 13 locales: Prime (Wisp/Hildryn) items, Mega Prime Vault packages, projections/relics, calendar/challenge entries, new mission type MT_ENDLESS_CAPTURE, new sol node DeimosHub, and renames "Exilus Adapter" → "Exilus Warframe Adapter". All edits are data additions or string updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (39)
🚧 Files skipped from review as they are similar to previous changes (18)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2024-12-17T20:05:33.832ZApplied to files:
📚 Learning: 2024-12-17T19:46:33.387ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (78)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
data/zh/solNodes.json (1)
1267-1271: Align Deimos parenthetical with existing zh convention.Elsewhere this file uses "(火卫二)" for Deimos (e.g., SolNode229, SolNode714). Recommend "Necralisk (火卫二)" for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
data/cs/languages.json(26 hunks)data/cs/missionTypes.json(1 hunks)data/cs/solNodes.json(1 hunks)data/de/languages.json(26 hunks)data/de/missionTypes.json(1 hunks)data/de/solNodes.json(1 hunks)data/es/languages.json(26 hunks)data/es/missionTypes.json(1 hunks)data/es/solNodes.json(1 hunks)data/fr/languages.json(26 hunks)data/fr/missionTypes.json(1 hunks)data/fr/solNodes.json(1 hunks)data/it/languages.json(26 hunks)data/it/missionTypes.json(1 hunks)data/it/solNodes.json(1 hunks)data/ko/languages.json(26 hunks)data/ko/missionTypes.json(1 hunks)data/ko/solNodes.json(1 hunks)data/pl/languages.json(26 hunks)data/pl/missionTypes.json(1 hunks)data/pl/solNodes.json(1 hunks)data/pt/languages.json(26 hunks)data/pt/missionTypes.json(1 hunks)data/pt/solNodes.json(1 hunks)data/ru/languages.json(26 hunks)data/ru/missionTypes.json(1 hunks)data/ru/solNodes.json(1 hunks)data/sr/languages.json(26 hunks)data/sr/missionTypes.json(1 hunks)data/sr/solNodes.json(1 hunks)data/tr/languages.json(26 hunks)data/tr/missionTypes.json(1 hunks)data/tr/solNodes.json(1 hunks)data/uk/languages.json(26 hunks)data/uk/missionTypes.json(1 hunks)data/uk/solNodes.json(1 hunks)data/zh/languages.json(26 hunks)data/zh/missionTypes.json(1 hunks)data/zh/solNodes.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
📚 Learning: 2024-12-17T20:05:33.832Z
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
Applied to files:
data/uk/solNodes.jsondata/es/solNodes.jsondata/sr/solNodes.jsondata/zh/solNodes.jsondata/tr/solNodes.jsondata/de/solNodes.jsondata/fr/solNodes.jsondata/pt/solNodes.jsondata/pl/solNodes.jsondata/cs/solNodes.jsondata/zh/languages.jsondata/pt/languages.jsondata/ko/languages.jsondata/es/languages.jsondata/ru/languages.jsondata/it/languages.jsondata/pl/languages.jsondata/tr/languages.jsondata/it/solNodes.jsondata/cs/languages.jsondata/sr/languages.jsondata/uk/languages.jsondata/de/languages.jsondata/fr/languages.json
📚 Learning: 2024-12-17T19:46:33.387Z
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: tools/translation.js:312-317
Timestamp: 2024-12-17T19:46:33.387Z
Learning: In `tools/translation.js` (JavaScript), the `eventTypeMap` should match the in-game event type translations exactly (one-to-one), and should not be modified to ensure consistency with the game's terminology.
Applied to files:
data/es/languages.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (90)
data/cs/languages.json (5)
32-43: Approve content additions for new Prime items and cosmetics.The additions for Hildryn Prime, Wisp Prime, and related Mega Prime Vault packages, projections/relics, ship decorations, and weapon entries appear well-formed and consistent with the existing JSON structure.
Also applies to: 65-112, 161-163, 230-232, 248-250, 419-427, 479-490
501-504: Approve calendar challenge entries.New challenge entries are properly formatted with value and description pairs and follow the established pattern.
Also applies to: 525-528
647-667: Approve Mega Prime Vault package entries.Entries for MPVHildrynPrimeSinglePack, MPVLarkspurGravimag, MPVWispHildrynPrimeDualPack, and MPVWispPrimeSinglePack are properly structured and follow naming conventions consistent with existing Mega Prime Vault entries.
Also applies to: 684-684, 692-697
790-793: Approve mission modifier and upgrade entries.New calendar modifiers and upgrade descriptions (ArtilleryBeacons, CompetitionSpillover, DrainingResiduals, ExplosiveEnergy, FallFog, GestatingTumors, HighScalingLegacyte, HostileSecurity, MutatedEnemies, NecramechActivation, StickyFingers, TankStrongArmor, WinterFrost, Withering, MagnetStatusPull) are consistently formatted with descriptive text and fit the existing data model.
Also applies to: 19302-19305, 19323-19326, 19343-19346, 19373-19376, 19381-19384, 19401-19404, 19417-19420, 19425-19428, 19452-19455, 19459-19462, 19544-19551, 19578-19585
617-619: Review comment is incorrect—no critical inconsistency exists.The two keys are distinct:
WeaponUtilityUnlocker(with "Weapon" prefix) andutilityunlocker(without). These represent two separate items in Warframe. The mappings are correct:WeaponUtilityUnlockercorrectly maps to "Exilus Weapon Adapter" (unlocks weapon slots), andutilityunlockercorrectly maps to "Exilus Warframe Adapter" (unlocks Warframe slots). This is not a duplicate key issue or data integrity error. No changes needed.Likely an incorrect or invalid review comment.
data/sr/missionTypes.json (1)
76-79: Mission type addition is properly formatted and consistent across locales.The MT_ENDLESS_CAPTURE entry is correctly added with proper JSON syntax. The untranslated English name "Legacyte Harvest" is consistent with the pattern observed across all language locales in this PR, suggesting this is an intentional proper name/mission type identifier.
data/zh/missionTypes.json (1)
76-79: Consistent addition across Chinese locale.The MT_ENDLESS_CAPTURE entry mirrors the additions in other language files with identical value "Legacyte Harvest". JSON syntax is correct.
data/tr/missionTypes.json (1)
76-79: Consistent with other locale additions.MT_ENDLESS_CAPTURE properly added with matching English name across all languages. JSON formatting is valid.
data/es/missionTypes.json (1)
76-79: Addition properly implemented for Spanish locale.The MT_ENDLESS_CAPTURE entry is correctly formatted and maintains consistency with other language files.
data/cs/missionTypes.json (1)
76-79: Czech locale update is consistent and correctly formatted.The new MT_ENDLESS_CAPTURE mission type is added with matching English name as seen in all other locales. JSON syntax is valid.
data/pt/solNodes.json (1)
1267-1271: DeimosHub entry is properly positioned and formatted.The new hub entry follows the established pattern for relay hubs, with correct structure (value, enemy, type fields). Logical placement before Deimos-specific nodes (SolNode706+) maintains file organization.
data/ru/missionTypes.json (1)
76-79: Russian locale addition is consistent with other languages.MT_ENDLESS_CAPTURE properly added with identical English value across all locales. JSON formatting is correct.
data/de/missionTypes.json (1)
76-79: German locale properly implements mission type addition.The MT_ENDLESS_CAPTURE entry is correctly added and maintains consistency with all reviewed language files. The untranslated English value "Legacyte Harvest" appears intentional, as it is preserved identically across all locales (Serbian, Chinese, Turkish, Spanish, Czech, Russian, and German).
data/pt/missionTypes.json (1)
74-79: ✓ Localization data addition is correctly formatted.The new
MT_ENDLESS_CAPTUREentry follows the established pattern: trailing comma added toMT_ALCHEMY(line 76), and the new mission type properly formatted with the untranslated value "Legacyte Harvest" (consistent across all language locales). JSON structure and syntax are valid.data/uk/missionTypes.json (1)
74-79: ✓ Ukrainian localization follows established pattern.Entry mirrors the Portuguese and other locale files:
MT_ALCHEMYtrailing comma corrected,MT_ENDLESS_CAPTUREproperly added with the consistent (untranslated) value "Legacyte Harvest". JSON structure valid.data/fr/missionTypes.json (1)
74-79: ✓ French localization data correctly integrated.Consistent structure across all mission type files:
MT_ALCHEMYtrailing comma, newMT_ENDLESS_CAPTUREentry with untranslated value. JSON formatting and syntax are correct.data/it/missionTypes.json (1)
74-79: ✓ Italian mission type data properly formatted.Follows established pattern: trailing comma added to
MT_ALCHEMY, newMT_ENDLESS_CAPTUREentry with consistent untranslated value "Legacyte Harvest". JSON structure valid.data/pl/missionTypes.json (1)
74-79: ✓ Polish mission type addition is correctly formatted.Consistent with all other locale files: proper trailing comma placement on
MT_ALCHEMY, newMT_ENDLESS_CAPTUREentry with the untranslated standard value. JSON structure is valid.data/pl/solNodes.json (1)
1267-1271: ✓ DeimosHub sol node correctly added.New hub node properly placed between
SolNode450andSolNode706, following the established hub node pattern (value, enemy, type fields). Trailing comma placement is correct for JSON continuation. Structure matches other hub nodes likeZarimanHubandSolNode234.data/de/solNodes.json (1)
1267-1271: ✓ German DeimosHub entry correctly localized.Hub node properly positioned and structured. German localization appropriately applied to the "type" field (
"Relais"for Relay), while location identifier"Necralisk (Deimos)"remains untranslated (consistent with pattern across other locales). JSON syntax and placement are correct.data/tr/solNodes.json (1)
1267-1271: ✓ Turkish DeimosHub entry correctly formatted.Hub node placed consistently with German and Polish locale files. Structure and field values are correct, with
"type": "Relay"following the existing Turkish localization pattern where certain game system values remain in English. JSON syntax is valid.data/ko/solNodes.json (1)
1267-1271: LGTM: DeimosHub added with correct KO hub conventions."텐노"/"릴레이" align with other hubs. No structural issues.
data/it/solNodes.json (1)
1267-1271: LGTM: matches IT file’s English-forward style.No localization or structural issues spotted.
data/es/solNodes.json (1)
1267-1271: LGTM: consistent with ES conventions."Repetidor" and "(Deimos)" align with surrounding entries. Structurally sound.
data/ko/missionTypes.json (1)
77-79: No action needed—KO localization is consistent with all other locales."Legacyte Harvest" is left in English across all 13 locale files (ko, de, cs, es, fr, it, pl, pt, ru, tr, sr, uk, zh), not just KO. This indicates the term is intentionally preserved in English (likely a proper name or brand), not a KO-specific localization gap.
Likely an incorrect or invalid review comment.
data/ru/solNodes.json (1)
1267-1271: Do not standardize Deimos naming; appears intentional per enemy type.The file does show inconsistency—nodes with "Заражённые" (Infested) enemy use "(Деймос)" while those with "The Murmur" or "Тэнно" use "(Deimos)". However, this distinction appears intentional and may reflect how Digital Extremes provides the underlying data. Per learnings on this repository, values sourced from DE should not be modified for consistency alone, as formatting differences often encode meaningful distinctions in the source data.
Likely an incorrect or invalid review comment.
data/sr/solNodes.json (1)
1267-1271: DeimosHub entry added consistently.The new hub entry follows the established naming and structure conventions seen in other files. JSON syntax is valid, and placement relative to SolNode450 is appropriate.
data/fr/solNodes.json (1)
1267-1271: DeimosHub entry with appropriate French localization.Type field correctly localized to "Relai" while maintaining the English proper noun "Necralisk (Deimos)" in the value field, following game localization conventions.
data/cs/solNodes.json (1)
1267-1271: DeimosHub entry added with consistent structure.Entry follows established conventions. Note: type field is "Relay" (English). If Czech translations for hub types exist elsewhere in this file, consider whether a Czech equivalent should be used here for consistency.
data/uk/solNodes.json (1)
1267-1271: DeimosHub entry with appropriate Ukrainian localization.Type field correctly localized to Ukrainian "Реле" while maintaining the English proper noun "Necralisk (Deimos)" in the value field, consistent with localization patterns used throughout the file.
data/pl/languages.json (5)
32-43: Review limited to visible structure only—Polish translations not visible in annotated code.The provided annotated code shows only the English
"value"fields and doesn't display the actual Polish translations being added to this file. To fully review this localization PR, I'll need to verify:
- Polish translation quality & accuracy – Do the Polish terms match the in-game UI and official Warframe terminology?
- Consistency with existing Polish entries – Do these new entries follow the same conventions, gender agreement, and pluralization rules as existing translations?
- Cross-locale alignment – As mentioned in the AI summary, do the Polish additions mirror the structure/style of other language files (ES, FR, IT, RU, KO, DE, SR, PT, ZH, TR, UK)?
- DE formatting compliance – Per the learning note, descriptions should not alter Digital Extremes' original formatting. Are the Polish descriptions faithful to DE's originals?
Without seeing the actual Polish text values in the file, this review cannot confirm translation accuracy. Please verify the Polish translations directly in the
data/pl/languages.jsonfile or provide a comparison showing Polish values alongside the English keys.Also applies to: 65-111, 161-231, 248-490
617-619: Distinct Exilus adapters correctly mapped to separate item keys.The PR correctly distinguishes between two separate items:
- Exilus Weapon Adapter unlocks an Exilus Mod Slot for Primary, Secondary or Melee weapons
- Exilus Warframe Adapter can be fused with a Warframe to unlock an Exilus Mod Slot
Lines 617–619 map
WeaponUtilityUnlockerto "Exilus Weapon Adapter", and Line 15437 mapsutilityunlockerto "Exilus Warframe Adapter"—two intentionally different products with separate item IDs, which is correct.Also applies to: 15437-15437
647-697: Mega Prime Vault package entries follow expected structure.The additions at lines 647–697 include new Mega Prime Vault packages (MPV*) with consistent key naming and structure. The entries follow the established pattern seen in adjacent lines (e.g., line 650–651, 668–669). Entries like
MPVHildrynPrimeSinglePack→ "Hildryn Prime Pack" andMPVWispPrimeSinglePack→ "Wisp Prime Pack" align with the AI summary description of Wisp/Hildryn Prime vault content.
501-527: Calendar challenge entries appear well-structured.The calendar challenge additions (hunks 10–11, lines 501–527) include both
valueanddescfields. Per the learning note, descriptions should remain faithful to Digital Extremes' originals without formatting modifications. While the structure is sound, verify that the Polish descriptions in these entries preserve DE's exact formatting and intent.Confirm that Polish descriptions in calendar challenge entries (lines 501–527) match DE's original text and formatting.
19302-19584: Large set of calendar/challenge modifier entries—structure consistent, descriptions need DE compliance check.Hunks 18–26 (lines 19302–19584) add numerous calendar/upgrade entries and mission modifiers (e.g.,
ArtilleryBeacons,CompetitionSpillover,DrainingResiduals,FallFog,GestatingTumors, etc.) withvalueanddescfields. The JSON structure is consistent with the rest of the file.However, per the learning note, upgrade descriptions must remain as provided by Digital Extremes without formatting modifications. This is particularly important for entries like lines 19373–19376 (
ExplosiveEnergy), 19381–19384 (FallFog), and others with detailed descriptions.Confirm that all Polish descriptions (especially for calendar upgrades and challenge modifiers, lines 19302–19584) match DE's official source text exactly, preserving any formatting quirks or inconsistencies from the original.
data/es/languages.json (3)
29-43: Prime item entries look correct.The additions for Hildryn Prime and Wisp Prime store items (hunks 1–9) follow the existing naming convention. Proper nouns and character names are correctly maintained in English across language locales, which is standard practice.
65-111: Void projection relic entries are well-structured.The new Wisp/Hildryn vault projections (hunks 2–4) with their corresponding relic tiers (Lith, Meso, Neo, Axi) maintain consistent naming with existing projection entries and appear complete.
19302-19305: Challenge descriptions are intentionally provided in English across all language files—not a localization issue.Verification confirms that challenge descriptions (like ArtilleryBeacons, Random, etc.) are consistently in English across German, Italian, Portuguese, French, and Spanish language files. This is an intentional pattern, not missing translations. The Spanish file itself contains properly translated content in other sections (e.g., "Tropa de élite localizada"), confirming the file's localization is working as intended. Challenge descriptions appear to be provided by Digital Extremes in English only and managed uniformly across all languages via Crowdin.
Likely an incorrect or invalid review comment.
data/ko/languages.json (2)
617-619: ****The two entries reference intentionally distinct items, not a casing or path inconsistency:
- Line 617:
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker→ "Exilus Weapon Adapter" (for weapons)- Line 15436:
/lotus/types/items/miscitems/utilityunlocker→ "Exilus Warframe Adapter" (for Warframes)Both paths and values are present consistently across all language files in the repository and match the base data file exactly. These represent two separate, correctly-implemented item types with distinct purposes.
Likely an incorrect or invalid review comment.
790-793: No issues found with DE-provided descriptions.Verification confirms that the calendar upgrade/challenge entries in the Korean file (
data/ko/languages.json) match the English source (data/languages.json) exactly:
- MagnetStatusPull: "Magnetic Status Effects also pull in enemies within 1m per stack." ✓
- ArtilleryBeacons: "When killed, Scaldra troops drop artillery beacons that summon bombardments." ✓
- DevilsBargain: "Allies within 4m of slain enemies gain 25% Fire Rate at the cost of -50% Ammo Efficiency." ✓
The descriptions are direct copies from the DE-provided English source without any modifications to formatting or content. Per the learning context, this satisfies the requirement that upgrade descriptions remain as provided by Digital Extremes.
data/ru/languages.json (4)
617-619: Exilus Adapter entries look appropriate.The two adapter entries (hunk 12: Weapon, hunk 17: Warframe) are correctly mapped to distinct internal paths and serve different purposes.
19302-19585: Challenge/upgrade entries are well-formatted and complete.All new challenge and upgrade modifier entries (hunks 18-26) include proper name and description pairs with specific game mechanic details and numeric values. Descriptions appear complete and grammatically sound.
65-70: Relic projection entries follow consistent naming conventions.The new Wisp/Hildryn vault relic entries (Lith L6, Lith F3, Meso G10, Neo H4, Axi W4, Axi S19) follow established naming patterns and map to correctly structured internal paths.
Also applies to: 80-91, 107-112
32-43: Running JSON validation to complete the verification:No issues found - language localization strategy is consistent across locales.
The Russian locale's mix of English (e.g., "Shade Prime") and Russian (e.g., "Вобан Прайм") follows the same pattern observed in other language files. Czech locale also retains English names for Prime Warframes, confirming this is intentional game design rather than a localization error. JSON syntax validation can proceed, but the entries reviewed align with localization standards used across the codebase.
data/zh/languages.json (12)
32-43: Approve store item additions for Hildryn Prime and Wisp Prime.The new entries are properly formatted and maintain consistency with existing Prime warframe naming conventions in the file.
65-111: Approve void projection relic entries for Wisp/Hildryn vaults.The six new relic entries are consistently named and properly ordered within their respective tiers (T1-T4). All entries follow the established English naming convention for relics.
161-163: Approve bobblehead entries for Hildryn Prime and Wisp Prime.Both entries follow the established naming pattern for Noggle decorations and are properly positioned within the file's alphabetical ordering.
Also applies to: 230-232
248-250: Approve Shade Prime sentinel powersuit entry.Entry is correctly formatted and maintains consistency with other Prime sentinel entries.
419-427: Approve Prime Syandana entries.Both entries follow established naming patterns and are properly positioned within the Syandana section.
479-490: Approve Prime weapon entries for Fulmin and Gunsen.Entries are properly formatted and maintain consistency with existing Prime weapon naming conventions.
501-527: Approve calendar challenge entries.Both entries are properly formatted with title and description fields. Descriptions remain as provided without modification, consistent with the project's policy on DE content.
617-619: Verify Exilus Adapter localization strategy.This entry provides a Chinese translation for WeaponUtilityUnlocker. However, a later entry at line 15436-15438 uses a different path (
/lotus/types/items/miscitems/utilityunlocker) with an English translation ("Exilus Warframe Adapter"). Clarify whether both entries should coexist or if one is meant to replace the other, as having duplicate entries for the same item with different paths and translations could cause conflicts.
647-697: Approve Mega Prime Vault package entries.All seven new package entries follow the established naming convention for MPV bundles and are correctly positioned within the section. English names are appropriate for product identifiers in this context.
790-793: Approve calendar upgrade entry for MagnetStatusPull.Entry is properly formatted with description following the project's policy of retaining DE-provided content as-is.
15436-15438: Verify consistency with earlier Exilus Adapter entry.This entry provides an English translation for a lowercase path. It duplicates the item from line 617-619, which uses a different path casing and a Chinese translation. Confirm whether both entries should exist (for different code paths) or if one is outdated. The inconsistency may cause unpredictable localization behavior.
19302-19585: Approve challenge modifier entries.All thirteen new modifier entries are properly formatted with descriptions following the project's policy of retaining DE-provided content unmodified. Entries are alphabetically positioned and naming is consistent with game terminology.
data/it/languages.json (9)
32-43: LGTM!The new Warframe Prime entries (Hildryn Prime and Wisp Prime) follow established naming conventions and are correctly mapped.
65-112: LGTM!The new relic projection entries for Wisp & Hildryn Prime vault follow established naming patterns and use valid relic designations.
161-490: LGTM!The cosmetics, accessories, and weapons entries (Noggle statues, Shade Prime, syandanas, and Prime weapons) follow established naming conventions and are correctly structured.
501-528: LGTM!The calendar challenge entries follow established naming patterns with clear challenge names and descriptions.
617-619: LGTM!The "Exilus Weapon Adapter" is the correct name for the item that unlocks an Exilus Mod Slot on Primary, Secondary or Melee weapons, distinct from the Exilus Warframe Adapter. The naming is accurate.
647-697: LGTM!The Mega Prime Vault package entries follow established naming conventions with clear descriptive names for single/dual packs and armor sets.
790-793: LGTM!The upgrade entry follows established patterns with a descriptive name and clear mechanical description.
15436-15438: LGTM!The "Exilus Warframe Adapter" is the correct name for the special item that can be fused with a Warframe to unlock an Exilus Mod Slot, distinct from the Exilus Weapon Adapter added earlier in the file.
19302-19585: LGTM!The new challenge and upgrade descriptor entries follow established patterns with clear names and detailed mechanical descriptions. As per learnings, the descriptions appear to be accurate localizations without modifications to the original formatting.
data/pt/languages.json (2)
32-43: Content additions are appropriately formatted localization data.The new entries for Prime items, relics, packages, challenges, and upgrades follow the established JSON structure and naming conventions throughout the file. Portuguese translations and game item names appear consistent with existing entries and follow the pattern visible in similar localization files across the project.
Also applies to: 65-112, 161-163, 230-232, 248-250, 419-427, 479-490, 501-528, 647-697, 790-793, 15302-15585
617-619: ****The flagged inconsistency is not an error. The two paths reference different game items:
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker→ "Exilus Weapon Adapter" (correct)/lotus/types/items/miscitems/utilityunlocker→ "Exilus Warframe Adapter" (correct)Script verification confirms this pattern is consistent across all locales (Chinese, Ukrainian, Serbian, Portuguese). These are distinct items with intentionally different values, not a data inconsistency requiring correction.
Likely an incorrect or invalid review comment.
data/tr/languages.json (3)
683-685: Rename verified as consistent across all locales.The
MPVOctaviaPrimeSinglePackentry shows "Octavia Prime Pack" consistently across all 13+ locale files (English, Italian, Polish, French, Ukrainian, Korean, Serbian, Portuguese, Russian, Turkish, Chinese, Spanish, Czech, German). This coordinated update across all locales indicates the change is intentional and translation alignment is maintained.
617-619: Let me check the English base locale to understand the intended translations for these distinct entries:The review comment is based on a false premise and should be disregarded.
The Exilus Weapon Adapter unlocks an Exilus Mod Slot on weapons, while the Exilus Warframe Adapter unlocks an Exilus Mod Slot on Warframes. These are two distinct in-game items, not the same item with conflicting translations.
The two locale entries are correctly mapped:
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker→ "Exilus Weapon Adapter" (correct for weapons)/lotus/types/items/miscitems/utilityunlocker→ "Exilus Warframe Adapter" (correct for Warframes)The path variations and different translations are intentional and reflect the different item types in Warframe's data structure.
Likely an incorrect or invalid review comment.
32-43: Cross-locale consistency verified and confirmed.The Turkish entries match the pattern used across all locales—proper nouns (Hildryn, Nezha, Wisp, and their Prime variants) remain in English with identical values in Turkish, English base, and Russian locales. The PR additions follow the established structure and naming conventions consistently.
data/fr/languages.json (5)
32-43: ✓ New Prime items, projections, and cosmetics look goodAll additions follow existing naming conventions consistently:
- Prime Warframes ("Hildryn Prime", "Wisp Prime")
- Void projection relics (e.g., "Lith L6 Relic", "Meso G10 Relic")
- Cosmetic items ("Noggle Statue - Hildryn Prime", "Shade Prime", Prime Syandanas, weapons)
Also applies to: 65-111, 161-231, 248-249, 419-426, 479-489
501-503: ✓ New calendar challenges properly formattedChallenge entries follow the established pattern with
valueanddescfields. Examples like "Starve the beast" and "By The Blade" are consistent with existing entries.Also applies to: 525-527
617-618: ✓ Exilus adapter terminology correctly distinguishedThe Exilus Weapon Adapter unlocks an Exilus Mod Slot for Primary, Secondary or Melee weapons, while the Exilus Warframe Adapter unlocks an Exilus Mod Slot for Warframes. The entries correctly use:
- Line 618: "Exilus Weapon Adapter" for
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker- Line 15437: "Exilus Warframe Adapter" for
/lotus/types/items/miscitems/utilityunlockerAlso applies to: 15437-15437
647-696: ✓ Mega Prime Vault packages consistently namedAll entries follow the pattern:
MPV[Name] → "[Display Name] Pack"(e.g., "Clearvoy Prime Collection", "Hildryn Prime Pack", "Wisp Prime Pack"). Line 684 updates "Octavia Prime" to "Octavia Prime Pack" for consistency across the dual-pack and single-pack variants.
790-792: ✓ Calendar descriptors properly formatted and translatedAll new calendar entries follow the standard two-field format (
value+desc) with clear, English descriptions. Examples:
- "Artillery Beacons" (line 19303), "Competitive Streak" (line 19324), "Devil's Bargain" (line 19345), "Sporogenesis" (line 19402)
- Descriptions are grammatically sound and contextually appropriate for game modifiers.
Consistent with the learnings: these are translations of Digital Extremes content without inappropriate formatting modifications.
Also applies to: 19302-19584
data/uk/languages.json (4)
790-793: English entry in MagnetStatusPull is systemic across all language files, not Ukrainian-specific.Verification confirms the Ukrainian file contains the MagnetStatusPull entry with English text ("Force Of Attraction" / "Magnetic Status Effects also pull in enemies within 1m per stack."), but this is identical to entries in all 12 language files (cs, de, es, fr, it, ko, pl, pt, ru, sr, tr, zh). This indicates the entry was intentionally provided in English across all languages by Digital Extremes, rather than representing incomplete Ukrainian localization. Per the project learning, upgrade descriptions should be preserved as provided by DE without modification.
Likely an incorrect or invalid review comment.
501-504: I need to verify if these English entries are new to this PR or intentional fallback content.Based on the verification, the original review comment is incorrect. Crowdin's default behavior fills untranslated strings with source text, but the script results reveal this is not a Ukrainian-specific localization issue.
All language files contain approximately 351 English entries (cs, de, es, fr, it, pl, pt, sr each have 351), indicating these English descriptions are consistent across the entire repository, not missing translations. The pattern—where entries like "Destroy 300 Containers" appear uniformly across all languages—shows these are intentional, not incomplete localization from Crowdin.
Per the learning note: "upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies." Game content descriptions are typically provided by DE and intentionally kept in English as source text, consistent with how Warframe handles English-language game content across all localized clients.
The English text in line 503 is correct and requires no changes.
Likely an incorrect or invalid review comment.
19302-19584: I need to verify if this pattern (all English across all languages) holds for other entries in the problematic section.Now let me verify this pattern with a few more entries and check the git history of this section:
Based on my verification, I can now see this is the Warframe-Hub repository (WFCD/warframe-hub). Let me check a couple more entries to fully confirm the pattern before finalizing:
Reframe the review: English entries are present uniformly across ALL language files, not just Ukrainian.
The issue identified in the review—English-only entries in the Ukrainian localization file—is actually present across all language files in the repository, not specific to Ukrainian. A test of the "ArtilleryBeacons" entry shows identical English values in all 13 supported language files (cs, de, es, fr, it, ko, pl, pt, ru, sr, tr, uk, zh).
This is expected behavior from Crowdin, which has native fallback to the source language for untranslated entries. Rather than indicating missing Ukrainian translations, this pattern indicates these entries are either:
- Newly added and awaiting translation in Crowdin (which would explain their presence in the export)
- Intentionally English (unlikely for a game UI localization, but possible for certain entry types)
This is not a Ukrainian-specific localization issue—it's a repository-wide Crowdin export characteristic that requires investigation of whether these entries have translations pending in the Crowdin project or are expected to remain in English.
Likely an incorrect or invalid review comment.
15437-15437: This review comment is incorrect. The untranslated "Exilus Warframe Adapter" entry is not a Ukrainian-specific issue.Verification shows that "Exilus Warframe Adapter" appears with identical English values across all 13+ language files (cs, de, es, fr, it, ko, pl, pt, ru, sr, tr, uk, zh, and base languages.json). This is not a Ukrainian localization gap—it reflects how Digital Extremes provided the data. The Ukrainian language file demonstrates working translations for other items, confirming the system supports Ukrainian localization. The untranslated state of this item is consistent across all languages and should be preserved as DE-provided, per codebase learnings.
Likely an incorrect or invalid review comment.
data/sr/languages.json (9)
32-43: Approve store items additions for Wisp and Hildryn Prime.The additions of Wisp Prime and Hildryn Prime store items follow the existing pattern and appear consistent with mirror translations from other language files.
65-111: Approve projection/relic entries.All T1-T4 void projection entries for Wisp/Hildryn Prime Vault items follow the correct naming convention and are consistent with the existing relic translation pattern.
161-232: Approve ship decoration (Noggle) entries.The Noggle statue additions for Hildryn Prime and Wisp Prime follow the established naming pattern and are structurally sound.
248-250: Approve sentinel skins and syandana entries.The additions for Shade Prime powersuit and Prime syandanas (Surator, Wisp) are consistent with existing patterns in the file.
Also applies to: 419-427
479-490: Approve weapon additions.The weapon entries for Fulmin Prime and Gunsen Prime follow the correct store item naming convention.
501-528: Approve challenge/calendar entries.The new calendar challenge entries are properly formatted with descriptors. Translations appear to follow the established pattern.
647-697: Approve Mega Prime Vault package entries.The comprehensive set of new Mega Prime Vault packages (Clearvoy, Hildryn, Larkspur, Wisp dual/single packs, etc.) are correctly structured and named consistently.
790-793: Approve upgrade and challenge modifier entries.The extensive set of new upgrades and challenge modifiers added throughout the file maintain consistent formatting with "value" and "desc" keys, following the established pattern.
Also applies to: 19302-19585
617-619: ****The original concern about naming inconsistency is unfounded. Verification across all language files confirms that both paths represent intentionally distinct game items:
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker→ "Exilus Weapon Adapter" (for weapons)/lotus/types/items/miscitems/utilityunlocker→ "Exilus Warframe Adapter" (for Warframes)This distinction is consistently maintained across all 13+ language files in the repository. The Serbian file (data/sr/languages.json) correctly follows this established pattern. These are separate items with different purposes and should have different translations.
Likely an incorrect or invalid review comment.
data/de/languages.json (2)
617-619: Adapter distinction verified across all language files.The verification confirms that both Exilus adapters are correctly distinguished:
- Weapon Adapter (
/Lotus/Types/Items/MiscItems/WeaponUtilityUnlocker): Consistently mapped to "Exilus Weapon Adapter" across all 14 language files- Warframe Adapter (
/lotus/types/items/miscitems/utilityunlocker): Consistently mapped to "Exilus Warframe Adapter" across all language filesThe PR correctly maintains this distinction. Both keys are used consistently, with the weapon adapter also appearing in store and blueprint variants. No issues found.
19302-19585: All game modifier descriptions verified as consistent with English source.The 11 modifiers in the German file (lines 19302–19584) have descriptions that match the base English file exactly. This pattern holds across all language files checked (German, French, Spanish), indicating that game modifier descriptions intentionally remain in English across all locales rather than being translated. No formatting deviations or inconsistencies were detected.
|
🎉 This PR is included in version 3.1.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
New Features
Items
✏️ Tip: You can customize this high-level summary in your review settings.