Skip to content

Conversation

@SlayerOrnstein
Copy link
Member

@SlayerOrnstein SlayerOrnstein commented Dec 16, 2025

What did you fix?

Apart from adding the new strings for the current operation I also fixed the incorrect mission types reported on Discord


Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? No
  • Does this introduce opinionated data formatting or manual data entry? No
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Bug Fix

Summary by CodeRabbit

  • New Features

    • Introduced Operation: Blood of Perita with new currency "Marks of Valiance" and rewards claimable in La Cathédrale
    • Added new mission location: Dark Refactory (Deimos)
    • Added new enemy designation "Anarch" and new mission type "The Perita Rebellion"
  • Updates

    • Rebalanced mission types across multiple nodes to increase gameplay variety

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Walkthrough

Added three localization/resource entries for "Operation: Blood of Perita" and introduced multiple mission node type changes plus a new Deimos node (SolNode251). All edits are additive/configuration changes to data files and a schema enum expansion; no runtime logic changes.

Changes

Cohort / File(s) Summary
Event localization & resource
data/languages.json
Added 3 new entries: /Lotus/Language/TauPrequel/TauPrequelFinal/BloodOfPeritaDetails, /Lotus/Language/TauPrequel/TauPrequelFinal/TauPrequelEventName ("Operation: Blood of Perita"), and /Lotus/Types/Gameplay/Tau/Resources/TwelveResourceCurrencyItem ("Marks of Valiance").
Sol node data & schema
data/solNodes.json, test/solNodes.spec.ts
Modified mission types for multiple nodes (SolNode11, 12, 33, 84, 88, 98, 742, 304, 223). Added SolNode251 (Deimos: "Dark Refactory", enemy "Anarch", type "The Perita Rebellion") — duplicated entry present. Updated schema/enums in test/solNodes.spec.ts to allow Anarch and The Perita Rebellion.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Review each solNodes type change for correctness and map progression impacts.
  • Remove or reconcile the duplicate SolNode251 entry; verify parser behavior with duplicates.
  • Confirm enum additions in test/solNodes.spec.ts match all locations where these values are validated or consumed.
  • Validate localization keys/strings for formatting and encoding.

Possibly related PRs

Suggested labels

released

Suggested reviewers

  • TobiTenno

Poem

🐰 I hopped through JSON, tidy and bright,
Added marks and a node in the night,
Rebalanced routes where missions roam,
A tiny patch to guide you home,
Celebrate operation—hop, delight! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions adding language strings for 'Operation: Blood of Perita', which aligns with the primary changes in data/languages.json but incompletely describes the full scope of changes, which also include significant mission type corrections in data/solNodes.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch langs

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccca808 and da96d75.

📒 Files selected for processing (1)
  • test/solNodes.spec.ts (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (2)
test/solNodes.spec.ts (2)

17-17: LGTM! New enemy type properly added.

The addition of 'Anarch' to the enemy enum is correctly positioned alphabetically and necessary to support the new Deimos node for Operation: Blood of Perita.


74-74: New mission type properly added to schema.

'The Perita Rebellion' is correctly positioned alphabetically between 'Survival' and 'Void Armageddon' in the solNodeType enum and is used in data/solNodes.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@SlayerOrnstein SlayerOrnstein merged commit 570ee0b into master Dec 16, 2025
11 checks passed
@SlayerOrnstein SlayerOrnstein deleted the langs branch December 16, 2025 22:54
@github-actions
Copy link

🎉 This PR is included in version 3.1.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai bot mentioned this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants