fix(l10n): new translations #789
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
📝 WalkthroughWalkthroughFormatting standardization applied across all language locale JSON data files: archonShards.json files reindented with consistent spacing, while languages.json, solNodes.json, and syndicatesData.json files received trailing newlines. No data content or structure modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@data/sr/archonShards.json`:
- Line 9: The JSON contains typoed user-facing strings (e.g., the "value"
entries "+150 Sheild Capacity" and occurrences of "Enery Orbs"); update those
string values to correct spelling—change "Sheild" to "Shield" and "Enery" to
"Energy" wherever those exact values appear (for example the "+150 Sheild
Capacity" entry and the "Enery Orbs" entries) so the "value" fields read "+150
Shield Capacity" and "Energy Orbs".
- Line 38: Two entries use the value "10% Ability Strength" without the leading
"+"; update both occurrences to "+10% Ability Strength" so they match the other
upgrade value formats (search for the exact string "10% Ability Strength" in the
JSON and replace it with "+10% Ability Strength" to fix the inconsistency).
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (52)
data/cs/archonShards.jsondata/cs/languages.jsondata/cs/solNodes.jsondata/cs/syndicatesData.jsondata/de/archonShards.jsondata/de/languages.jsondata/de/solNodes.jsondata/de/syndicatesData.jsondata/es/archonShards.jsondata/es/languages.jsondata/es/solNodes.jsondata/es/syndicatesData.jsondata/fr/archonShards.jsondata/fr/languages.jsondata/fr/solNodes.jsondata/fr/syndicatesData.jsondata/it/archonShards.jsondata/it/languages.jsondata/it/solNodes.jsondata/it/syndicatesData.jsondata/ko/archonShards.jsondata/ko/languages.jsondata/ko/solNodes.jsondata/ko/syndicatesData.jsondata/pl/archonShards.jsondata/pl/languages.jsondata/pl/solNodes.jsondata/pl/syndicatesData.jsondata/pt/archonShards.jsondata/pt/languages.jsondata/pt/solNodes.jsondata/pt/syndicatesData.jsondata/ru/archonShards.jsondata/ru/languages.jsondata/ru/solNodes.jsondata/ru/syndicatesData.jsondata/sr/archonShards.jsondata/sr/languages.jsondata/sr/solNodes.jsondata/sr/syndicatesData.jsondata/tr/archonShards.jsondata/tr/languages.jsondata/tr/solNodes.jsondata/tr/syndicatesData.jsondata/uk/archonShards.jsondata/uk/languages.jsondata/uk/solNodes.jsondata/uk/syndicatesData.jsondata/zh/archonShards.jsondata/zh/languages.jsondata/zh/solNodes.jsondata/zh/syndicatesData.json
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
📚 Learning: 2024-12-17T20:05:33.832Z
Learnt from: SlayerOrnstein
Repo: WFCD/warframe-worldstate-data PR: 588
File: data/languages.json:18862-18865
Timestamp: 2024-12-17T20:05:33.832Z
Learning: In `data/languages.json`, upgrade descriptions should remain as provided by Digital Extremes (DE) without modifying formatting inconsistencies.
Applied to files:
data/ru/solNodes.jsondata/pl/archonShards.jsondata/ru/archonShards.jsondata/de/syndicatesData.jsondata/tr/languages.jsondata/es/archonShards.jsondata/uk/archonShards.jsondata/sr/languages.jsondata/fr/languages.jsondata/fr/solNodes.jsondata/de/languages.jsondata/ru/languages.jsondata/es/languages.jsondata/zh/archonShards.jsondata/ru/syndicatesData.jsondata/tr/archonShards.jsondata/de/archonShards.jsondata/it/archonShards.jsondata/it/languages.jsondata/zh/languages.jsondata/sr/archonShards.jsondata/uk/languages.jsondata/fr/archonShards.jsondata/pl/languages.jsondata/cs/archonShards.jsondata/ko/archonShards.jsondata/pt/languages.jsondata/ko/languages.jsondata/cs/languages.jsondata/pt/archonShards.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (53)
data/it/languages.json (1)
19604-19604: LGTM! Trailing newline standardization.This formatting change adds a trailing newline at the end of the file, which is a standard best practice for version control systems and aligns with POSIX line definitions. The change doesn't affect the JSON structure or translation content.
data/ru/solNodes.json (1)
2247-2247: LGTM! Trailing newline added per formatting standards.This formatting change adds a trailing newline to the file, which is a standard best practice and aligns with the PR's objective of formatting standardization across locale files. No translation data has been modified.
data/fr/languages.json (1)
19604-19604: LGTM! Standard formatting improvement.Adding a trailing newline at the end of the file is a standard best practice and aligns with POSIX text file conventions. This non-functional change improves consistency across the codebase.
data/ru/languages.json (1)
19604-19604: LGTM! Standard EOF formatting applied.Adding a trailing newline at the end of the file aligns with POSIX standards and common coding conventions.
data/zh/solNodes.json (1)
2247-2247: LGTM! Standard formatting improvement.Adding a trailing newline is a standard practice that improves version control handling and complies with POSIX text file standards. This non-functional change has no impact on the localization data.
data/uk/languages.json (1)
19604-19604: LGTM: Standard EOF formatting improvement.Adding a trailing newline at the end of the file aligns with common best practices and improves POSIX compliance. No content or structure modifications.
data/tr/solNodes.json (1)
2247-2247: LGTM! Standard formatting improvement.Adding a trailing newline at the end of the file is a standard practice that ensures POSIX compliance and consistency with most code style guidelines.
data/pt/solNodes.json (1)
2247-2247: LGTM! Standard formatting improvement.Trailing newline added for POSIX compliance and consistency with coding standards.
data/ko/solNodes.json (1)
2247-2247: LGTM! Standard formatting improvement.Trailing newline added for consistency across locale files.
data/pt/archonShards.json (1)
1-224: LGTM! Formatting standardization applied.The indentation and spacing have been normalized throughout the file. The AI summary confirms no data content or structure modifications were made—only whitespace and formatting adjustments. This aligns with the broader PR's goal of standardizing formatting across locale files.
data/cs/solNodes.json (1)
2247-2247: LGTM! Standard formatting improvement.Trailing newline added, consistent with other locale files in this PR.
data/ko/syndicatesData.json (1)
86-86: LGTM!Trailing newline addition aligns with POSIX standard and improves consistency across locale files.
data/uk/syndicatesData.json (1)
86-86: LGTM!Trailing newline addition is consistent with the formatting standardization across other locale files.
data/es/solNodes.json (1)
2247-2247: LGTM!Trailing newline addition maintains consistency with the formatting standardization applied across locale data files.
data/tr/syndicatesData.json (1)
86-86: LGTM!Trailing newline addition is consistent with the PR's formatting standardization across locale files.
data/de/syndicatesData.json (1)
86-86: LGTM!Trailing newline addition completes the formatting standardization. The German translation content remains unchanged, which aligns with the learning to preserve data as provided by Digital Extremes.
data/it/archonShards.json (1)
1-224: LGTM! Formatting standardization applied.The indentation and spacing adjustments improve consistency across the locale data files without modifying any data content or structure.
data/sr/solNodes.json (1)
2247-2247: LGTM! Trailing newline added.Standard EOF formatting improvement with no functional impact.
data/de/solNodes.json (1)
2247-2247: LGTM! Trailing newline added.Standard EOF formatting improvement with no functional impact.
data/sr/syndicatesData.json (1)
86-86: LGTM! Trailing newline added.Standard EOF formatting improvement with no functional impact.
data/fr/solNodes.json (1)
2247-2247: LGTM! Trailing newline added.Standard EOF formatting improvement with no functional impact.
data/pl/languages.json (1)
19604-19604: LGTM! Trailing newline added for standardization.This formatting change aligns with common coding standards and improves consistency across locale files.
data/ru/syndicatesData.json (1)
86-86: LGTM - Standard EOF formatting.Adding a trailing newline is a standard formatting improvement that aligns with common file conventions.
data/pt/syndicatesData.json (1)
86-86: LGTM - Standard EOF formatting.Adding a trailing newline is a standard formatting improvement that aligns with common file conventions.
data/ru/archonShards.json (1)
1-224: Formatting improvements are good and don't introduce new issues.The indentation standardization improves consistency. The English text and typos ("Sheild" on lines 9, 120 and "Enery" on lines 52, 163) are pre-existing across all archonShards.json files in the repository, including the source file, indicating they originate from Digital Extremes' data. Some locales have been translated (Spanish, Chinese, Ukrainian) while others use English as a fallback; this mixed approach appears intentional. Since this PR preserves the provided content without modification, the formatting improvements can be approved.
data/tr/languages.json (1)
19601-19604: LGTM! Standard formatting improvement.Adding a trailing newline at the end of the file follows common text file conventions and improves compatibility with various tools without affecting JSON parsing or data integrity.
data/es/languages.json (1)
19604-19604: LGTM! Standard EOF newline addition.Adding a trailing newline at the end of the file follows POSIX conventions and is consistent with the formatting standardization applied across locale files in this PR.
data/sr/languages.json (1)
19601-19604: LGTM! Standard EOF newline formatting.Adding a trailing newline at the end of the file follows POSIX standards and improves consistency across locale files. This formatting change has no functional impact.
data/sr/archonShards.json (2)
1-224: LGTM! Formatting standardization applied correctly.The JSON indentation and spacing have been standardized appropriately across the file without modifying any data content or structure.
1-224: This is a project-wide localization gap, not a Serbian-specific issue.The
data/sr/archonShards.jsonfile contains English text, but this is consistent with most other locale files (Czech, German, French, Italian, Korean, Polish, Portuguese, Russian). Only Spanish and Chinese have translations implemented. If Serbian translations are needed, they should be part of a broader localization effort across multiple locales rather than treated as an isolated Serbian locale problem.data/de/languages.json (1)
19604-19604: LGTM! Standard EOF formatting applied.The addition of a trailing newline at the end of the file follows POSIX conventions and is a standard formatting practice. This change doesn't modify any JSON data or structure.
data/pt/languages.json (1)
19604-19604: LGTM! Trailing newline addition follows best practices.Adding a trailing newline to the file is a standard formatting practice that aligns with many style guides and improves consistency across the codebase. This change has no functional impact on JSON parsing or data content.
data/pl/solNodes.json (1)
2247-2247: LGTM! Trailing newline added for POSIX compliance.The addition of a trailing newline is a formatting best practice that aligns with POSIX standards and improves consistency across the codebase.
data/es/syndicatesData.json (1)
86-86: LGTM! Trailing newline added for consistency.The trailing newline addition follows standard formatting conventions and maintains consistency with other locale files in this PR.
data/tr/archonShards.json (1)
1-224: LGTM! Formatting standardization applied.The reindentation improves consistency and readability without modifying any data content, keys, or values. This aligns with the formatting standardization objective across locale files.
data/fr/syndicatesData.json (1)
86-86: LGTM! Trailing newline added for consistency.The trailing newline addition maintains consistency with formatting standards across all locale files.
data/zh/syndicatesData.json (1)
86-86: LGTM! Trailing newline added for consistency.The trailing newline addition completes the formatting standardization across all locale syndicate data files in this PR.
data/cs/syndicatesData.json (1)
86-86: LGTM! EOF newline standardization.The addition of a trailing newline at the end of the file follows POSIX standards and aligns with the formatting standardization applied across all locale files in this PR.
data/uk/solNodes.json (1)
2247-2247: LGTM! EOF newline standardization.The trailing newline addition is a non-functional formatting improvement that follows POSIX conventions and aligns with the broader formatting standardization in this PR.
data/zh/archonShards.json (1)
1-224: LGTM! Consistent indentation standardization.The reindentation changes throughout this file are purely formatting improvements with no semantic impact. All keys and values remain unchanged, and the JSON structure is valid.
data/pl/syndicatesData.json (1)
86-86: LGTM! EOF newline standardization.The addition of a trailing newline is a beneficial formatting improvement that maintains consistency with other locale files in this PR.
data/es/archonShards.json (1)
1-224: LGTM! Consistent indentation standardization.The reindentation applied throughout this file is purely a formatting improvement with no functional changes. All data content remains intact, and the formatting now matches the standardization applied across other archonShards.json locale files.
data/cs/languages.json (1)
19604-19604: LGTM! Trailing newline addition improves file formatting.Adding a trailing newline at the end of the file is a standard best practice and aligns with the PR's formatting standardization objectives. No data content or structure has been modified.
data/zh/languages.json (1)
19604-19604: LGTM! Trailing newline added for formatting consistency.This formatting change adds a trailing newline at the end of the file, which is a common best practice and aligns with the PR's goal of formatting standardization across locale files.
data/ko/languages.json (1)
19604-19604: LGTM! Standard formatting improvement.Adding a trailing newline at the end of the file is a standard best practice and has no functional impact on JSON parsing or data integrity.
data/fr/archonShards.json (1)
1-224: LGTM - Formatting standardization applied correctly.The indentation and spacing adjustments are consistent throughout the file. Note: The typos in values (e.g., "Sheild", "Enery") are from Digital Extremes' original data and should remain unchanged. Based on learnings, upgrade descriptions should remain as provided by DE without modifying formatting inconsistencies.
data/it/solNodes.json (1)
2247-2247: LGTM - Trailing newline added.Standard EOF newline addition for POSIX compliance. No data changes.
data/it/syndicatesData.json (1)
86-86: LGTM - Trailing newline added.Standard EOF newline addition. No data changes.
data/cs/archonShards.json (1)
1-224: LGTM - Formatting standardization applied correctly.Consistent indentation and spacing adjustments. The DE-provided typos in values are correctly preserved per project conventions.
data/pl/archonShards.json (1)
1-224: LGTM - Formatting standardization applied correctly.Consistent with other locale archonShards.json files in this PR. No data changes, only whitespace/indentation adjustments.
data/ko/archonShards.json (1)
1-224: Formatting standardization applied successfully.The reindentation and spacing changes align with the PR objectives for consistent formatting across locale files.
data/de/archonShards.json (1)
1-224: Formatting standardization applied successfully.The reindentation and spacing changes align with the PR objectives for consistent formatting across locale files.
data/uk/archonShards.json (1)
1-224: Formatting standardization applied successfully.The reindentation and spacing changes align with the PR objectives for consistent formatting across locale files.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.