Skip to content

Conversation

@Da-Be-Ru
Copy link
Member

@Da-Be-Ru Da-Be-Ru commented Nov 14, 2025

If the ringsector in commongrids.jl is called as a fullcircle, the final iarc iteration pushes nrad points into the coord array, but rightly skips setting the CellNodes for those so we get orphaned dangling nodes not assigned to any cells.

This causes some issues downstream which would be ironed out with these modifications suggested by @chmerdon

Additionally, setting the coordinate value type Tv to the standard Float64 stabilizes the cell lookups for gFindLocal! properly (fixing the excessively large runtimes of lazy_interpolate!).

j-fu added 4 commits November 14, 2025 13:54
- use promote_type to determine coordinate type
- Remove unused eltype kwarg (it was a bad idea anyway to name it this way)
@j-fu
Copy link
Member

j-fu commented Nov 14, 2025

Thanks for the catch!
We should have tested for this long before.
Any ideas for more consistency checks ? If yes, make a new PR. Lets not do this here in order to get this finished quickly.

@j-fu j-fu merged commit 624eeef into master Nov 15, 2025
26 of 27 checks passed
@j-fu j-fu deleted the fix/commongrids_ringsector branch November 15, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants