Conversation
|
|
||
| ISSUE: The above definitions of from and to probably don't do the right thing | ||
| during the loading of the new document in a cross-document navigation, | ||
| since I think they reference concepts that are only present on the old document. |
There was a problem hiding this comment.
They also don't exactly work for the outgoing document in a cross-document navigation.
I think these definitions would currently only work for same-document navigations, and the notes should reflect ths.
There was a problem hiding this comment.
I haven't managed to figure out why they don't work for cross-document navigations (at least if same-origin)... could you briefly say why they don't?
There was a problem hiding this comment.
Actually they do.
Where they don't work is when you start a same-doc navigation like pushState in the middle of a cross-doc navigation. But perhaps that's an OK edge case to not support.
There was a problem hiding this comment.
OK, I've added another issue mentioning that case, and I'll go ahead and merge.
This one mentions problems when starting a same-document navigation in the middle of a cross-document navigation.
SHA: 4409f3b Reason: push, by dbaron Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
This sort of fills in (modulo some issues noted in the text) the placeholders that I left in the definitions of "from" and "to".
(I'm curious if @noamr agrees with my description of the issue.)