Also match from/to based on navigation.activation information.#58
Merged
Also match from/to based on navigation.activation information.#58
Conversation
noamr
reviewed
Oct 3, 2025
Collaborator
noamr
left a comment
noamr
left a comment
There was a problem hiding this comment.
On the right track, but needs to be slightly more precise!
noamr
reviewed
Oct 3, 2025
noamr
approved these changes
Oct 3, 2025
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2025
SHA: 77aa3ef Reason: push, by dbaron Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some wording to also consider
navigation.activationbased on a suggestion from @noamr. I suspect this fully resolves the issue that I deleted in this PR (visible in current spec for now), but I'd definitely like @noamr to check that he agrees.The way this integrates with "reveal a document" is pretty monkeypatch-ey, but I think it's fine for now and we should fix it later as this stabilizes.
Also curious if @noamr has an opinion on whether the "transition" lifetime or the "ongoing navigate event" lifetime is correct -- I think they differ when the navigate event is intercepted. (I turned that from a code comment into an actual
ISSUEin this PR.)