Clean up script-initiated patching example#90
Merged
Conversation
tunetheweb
commented
Mar 5, 2026
| await writer.write(` | ||
| <template for=result> | ||
| <?start name=results> | ||
| <template for=results#next-result> |
Collaborator
Author
There was a problem hiding this comment.
This could also be just results as doesn't need the named part since it's replacing the whole template anyway:
Suggested change
| <template for=results#next-result> | |
| <template for=results> |
But I think it's cleaner to be the same as the next insert.
noamr
approved these changes
Mar 5, 2026
github-actions bot
added a commit
that referenced
this pull request
Mar 5, 2026
SHA: cc14aee Reason: push, by noamr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #87 we can simplify this example.
Also the current example doesn't work (as it's
<template for=result>instead of<template for=results>).